-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solved issue "Enhancement to MEWS Score" #7438
Solved issue "Enhancement to MEWS Score" #7438
Conversation
@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
@rithviknishad, please remove stale label |
❌ Deploy Preview for care-net failed.
|
the deploy build is failing fix it |
@nihal467 first need to merge the backend then the test will be passed |
@r-nikhilkumar ig the problem is with the typescript errors , see the screenshot attached |
@rash-27 yeah, sorry I didn't see ss |
@r-nikhilkumar We've recently introduced type-checks at the build step to voluntarily fail the build if there were type errors. This was done to improve code quality and catch potential bugs early on before it even gets merged. Ref: #7469 It'd be appreciated if you could fix the type errors introduced in this PR. |
…ub.com/r-nikhilkumar/care_fe into Enhancement_to_MEWS_Score_#7373_solved
@nihal467 solved the typeError now you can test it, sorry for inconvenience |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proper types needed. Setting to any
defeats the purpose of enforcing type-safety.
👋 Hi, @r-nikhilkumar, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
discussion is going on in the backend repo : ohcnetwork/care#1991 |
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
👋 Hi, @r-nikhilkumar, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
@r-nikhilkumar closing this PR and unassigning you from this issue due to inactivity, feel free to reopen the same if you are still working on it |
@nihal467 is the issue still in progress and not resolved, why you reopened this my PR?🤔 |
@r-nikhilkumar #7373 (comment) , can you post a reply to this message |
Closing this PR due to lack of recent progress. |
depends on ohcnetwork/care#1991
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers