Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue "Enhancement to MEWS Score" #7438

Conversation

r-nikhilkumar
Copy link
Contributor

@r-nikhilkumar r-nikhilkumar commented Mar 19, 2024

  • Fixes Enhancement to MEWS Score #7373
  • Allow calculation of MEWS score by fetching the relevant 5 data points spread across multiple log updates filed within a time frame of 30 min✅
  • Add measured at time under the MEWS on Patient dashboard. mention the time stamp of the latest of the 5-parameters✅

depends on ohcnetwork/care#1991

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@r-nikhilkumar r-nikhilkumar requested a review from a team as a code owner March 19, 2024 13:13
Copy link

vercel bot commented Mar 19, 2024

@r-nikhilkumar is attempting to deploy a commit to the Open Healthcare Network Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 240ae1a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/662a9ac9230be400081e0985
😎 Deploy Preview https://deploy-preview-7438--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 28, 2024
@r-nikhilkumar
Copy link
Contributor Author

@rithviknishad, please remove stale label

Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 55754ad
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/660c2a6e2dca0400088647bf

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 2, 2024
@nihal467
Copy link
Member

nihal467 commented Apr 2, 2024

@r-nikhilkumar
image

the deploy build is failing fix it

@r-nikhilkumar
Copy link
Contributor Author

@nihal467 first need to merge the backend then the test will be passed

@rash-27
Copy link
Contributor

rash-27 commented Apr 3, 2024

@r-nikhilkumar ig the problem is with the typescript errors , see the screenshot attached

@r-nikhilkumar
Copy link
Contributor Author

@rash-27 yeah, sorry I didn't see ss

@rithviknishad
Copy link
Member

@r-nikhilkumar We've recently introduced type-checks at the build step to voluntarily fail the build if there were type errors. This was done to improve code quality and catch potential bugs early on before it even gets merged. Ref: #7469

It'd be appreciated if you could fix the type errors introduced in this PR.

@r-nikhilkumar
Copy link
Contributor Author

@nihal467 solved the typeError now you can test it, sorry for inconvenience

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proper types needed. Setting to any defeats the purpose of enforcing type-safety.

Copy link

👋 Hi, @r-nikhilkumar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 15, 2024
@Ashesh3 Ashesh3 removed the merge conflict pull requests with merge conflict label Apr 15, 2024
@nihal467
Copy link
Member

discussion is going on in the backend repo : ohcnetwork/care#1991

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 24, 2024
@github-actions github-actions bot removed the stale label Apr 26, 2024
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 7, 2024
Copy link

github-actions bot commented May 7, 2024

👋 Hi, @r-nikhilkumar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@r-nikhilkumar closing this PR and unassigning you from this issue due to inactivity, feel free to reopen the same if you are still working on it

@nihal467 nihal467 closed this May 14, 2024
@nihal467 nihal467 reopened this Aug 19, 2024
@r-nikhilkumar
Copy link
Contributor Author

@nihal467 is the issue still in progress and not resolved, why you reopened this my PR?🤔

@nihal467
Copy link
Member

nihal467 commented Sep 6, 2024

@r-nikhilkumar #7373 (comment) , can you post a reply to this message

@bodhish
Copy link
Member

bodhish commented Sep 20, 2024

Closing this PR due to lack of recent progress.

@bodhish bodhish closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend discussion required merge conflict pull requests with merge conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement to MEWS Score
6 participants