Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure RelativeTime component's text representation is client side computed #422

Closed
rithviknishad opened this issue Apr 3, 2024 · 6 comments · Fixed by #520
Closed

Ensure RelativeTime component's text representation is client side computed #422

rithviknishad opened this issue Apr 3, 2024 · 6 comments · Fixed by #520
Assignees
Labels

Comments

@rithviknishad
Copy link
Member

rithviknishad commented Apr 3, 2024

When relative time is rendered in an statically generated route, the relative value is no longer correct as it does not change based on the time of the request.

Solution:
Relative time to be a client component, and representable relative time text to be computed at client side

image
@rithviknishad rithviknishad self-assigned this Apr 3, 2024
@rithviknishad rithviknishad removed their assignment Sep 27, 2024
@rithviknishad rithviknishad changed the title Issue with rendering relative time in server side (ISR/pre-render) Ensure RelativeTime component's text representation is client side computed Sep 27, 2024
@Jash2606
Copy link
Contributor

Jash2606 commented Oct 1, 2024

Hey @rithviknishad ,
I'd like to contribute to this issue for Hacktoberfest . Could you please assign it to me?

@Jash2606
Copy link
Contributor

Jash2606 commented Oct 1, 2024

Hey @rithviknishad,

I'm encountering an issue with my project where the website looks different on the live version compared to my localhost setup.

Live Version:

image

Localhost Version:

Screenshot 2024-10-02 010026

As you can see, there are discrepancies in the appearance. Could you help me identify the root cause and figure out a solution to make both versions consistent?

@rithviknishad
Copy link
Member Author

You mean the data present in both is different? Or the layout?

@Jash2606
Copy link
Contributor

Jash2606 commented Oct 3, 2024

You mean the data present in both is different? Or the layout?

Both things are different in live version and in localhost

@rithviknishad
Copy link
Member Author

data being different is likely because your local data-repo is outdated.

layout, I don't see any difference.

@Jash2606
Copy link
Contributor

Jash2606 commented Oct 3, 2024

Hey @rithviknishad ,
I'd raised PR for above issue , Could you review it and let me know if any further changes required !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants