Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Delete mistake sheets created with cutlines #147

Open
rchampine opened this issue Sep 5, 2023 · 6 comments
Open

[Request] Delete mistake sheets created with cutlines #147

rchampine opened this issue Sep 5, 2023 · 6 comments
Labels
type: enhancement New feature or request
Milestone

Comments

@rchampine
Copy link

There does not appear to be a way to delete new layers (sheets marked with [x]) that are created from the preparation stage. Since it's possible to accidentally create new sheets from an imprecise cutline, it would be beneficial to be able to remove these extraneous items. Ideally, this ability to delete would only be available on newly created sheets, perhaps only by a subset of users, and not sheets loaded directly from LOC.

Example: Savannah, Ga. | 1955 | Vol. 1 p50 [3]

image
@rchampine rchampine added the type: enhancement New feature or request label Sep 5, 2023
@rchampine rchampine changed the title Delete mistake sheets created with cutlines [Request] [Request] Delete mistake sheets created with cutlines Sep 5, 2023
@mradamcox
Copy link
Collaborator

@rchampine There is a way to do this, it is just not well-documented, or very intuitive. You have to go to the resource page for the parent and, if you are logged in, you'll see an "undo" button there in the Preparation section:
image. In this particular case, it should work perfectly fine. If one of the "down-stream" documents has already been georeferenced, then the button will be disabled, until the georeferencing session has been deleted which only an admin can currently do.

This whole side of things should really be reworked. I've been thinking for a while about adding a "staff user" level, or something along those lines, which would allow me to add more controls to the frontend that only appear for a few people. Will make a new ticket for that though.

@rchampine
Copy link
Author

Ah I see! I missed the link to the parent resource page. I just tried this and it seems to have worked — but with one hiccup:

The children of the mistaken cutline are all 404'd now (as expected):
https://oldinsurancemaps.net/resource/7823
https://oldinsurancemaps.net/resource/7824
https://oldinsurancemaps.net/resource/7825

But their previews and dead links still appear under Prepared in the volume summary: https://oldinsurancemaps.net/loc/sanborn01500_008/#prepared

@mradamcox
Copy link
Collaborator

Ah, ok, that should get cleared up if you click the Repair Summary button on the volume page (at the top of the Georeferencing Overview). If that does work I'll make a separate ticket because that cleanup operation should be triggered by the undo operation.

@rchampine
Copy link
Author

Nice — the Repair Summary button worked.

@rchampine
Copy link
Author

I expect having to do this will be pretty rare (and handled by me for DSL students) so I wouldn't prioritize this enhancement. I think the overall takeaway for me is that a "delete sheet" button on the child page rather than the parent page would be useful/more intuitive (and could preserve any valid crops). Thanks for your help on this!

@mradamcox
Copy link
Collaborator

Yeah, that makes a lot of sense for sure, it's just that at the moment this split operation is handled as a whole, kind of an all or nothing setup. Some re-modeling that I have in mind could remove that constraint, but for it'll have to stay this way. I could still put an "undo" button on the child sheets with more clear instructions, so I'll leave this ticket open until I can get to that.

@mradamcox mradamcox added this to the Next Tasks milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants