Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crop never returns an error #8

Open
mikepulaski opened this issue Jul 19, 2018 · 1 comment
Open

Crop never returns an error #8

mikepulaski opened this issue Jul 19, 2018 · 1 comment

Comments

@mikepulaski
Copy link

Looking through the Crop function, it looks as though it never calls a method which would return an error.

It'd be nice if the Crop method did not have a signature which suggests otherwise.

@montanaflynn
Copy link

Even better if it did some boundary checking and did return an error. It's possible to try to crop an image outside the dimensions which just returns an 0x0 image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants