Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: jp2 (jpeg 2000) support #326

Open
1 task done
Alexisback opened this issue Feb 6, 2025 · 5 comments
Open
1 task done

[Feature Request]: jp2 (jpeg 2000) support #326

Alexisback opened this issue Feb 6, 2025 · 5 comments

Comments

@Alexisback
Copy link

Preflight Checklist

  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe your suggested feature

I have zip files, with jp2 (jpeg 2000) inside but OpenComic does not read them even if I renamed the file to .cbz.
Another program SumatraPDF instead reads them.
Is it possible to insert the jp2 display in OpenComic?
Thank you

Additional Information

No response

Sample file

Corriere dei piccoli 1908-01 originale_jp2.zip

@ollm
Copy link
Owner

ollm commented Feb 6, 2025

Thanks for the suggestion!

Currently OpenComic does not support jp2 images. You can see the currently supported formats here.

But I will try to see if I can add it support in the next major version.

@ollm ollm added this to the v1.5.0 milestone Feb 6, 2025
@ollm
Copy link
Owner

ollm commented Feb 10, 2025

I'm happy to say that I've added support for JPEG 2000 via e11046b.

If you want to try it to see if there are any bugs, I'll leave you a build of the master branch.

Buid: https://mega.nz/file/aLRBiSBC#NRUurPtVW_XLd9n_CFVOIz-xrMc6lXY_gETfdFIGwzQ

Image

Image

@ollm ollm self-assigned this Feb 10, 2025
@Alexisback
Copy link
Author

Great, I'm testing, but the file loading is a bit slow, in SumatraPDF it's almost instantaneous, maybe everything can be speeded up.

https://www.upload.ee/files/17731435/Corriere_dei_piccoli_1991-16_jp2.cbz.html

@ollm
Copy link
Owner

ollm commented Feb 11, 2025

I've made some changes to improve performance 7a6b487, it should now load much faster, especially if the file has a lot of images, although it won't go as fast as other images (jpg, png, etc) but it should be acceptable.

I've also improved the speed at which thumbnails are generated 155f064

Build: https://mega.nz/file/fKAxHazb#wJ7iaFe40_Myes3iJlMh5ypuyh6rLHjOw8L9uvH7Z4w

@Alexisback
Copy link
Author

Yes, it loads very fast now.
If there are other features to add I suggest it.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants