equals() comparing objects of different types

[scuniff]

https://github.com/ome/omero-server/blob/master/src/main/java/ome/services/ThumbnailBean.java#L1141

Looks like this code at line 1141 is not comparing objects of the same type

if (inProgress && !PROGRESS_VERSION.equals(thumbnailMetadata)) {

==================

Should the getVersion() method be added:

if (inProgress && !PROGRESS_VERSION.equals(thumbnailMetadata.getVersion())) {

like it is at line 1042?

[joshmoore]

Wow. Thanks, @scuniff! That looks very much to be the case. Would you be interested in opening a PR?

[scuniff]

It's been over a year since I've used Git, didn't realize how rusty I am. 😊

Please let me know how this Pull Request looks and if there's something more or different I should do to follow OME processes.

#168

Thanks,
Steve

[joshmoore]

Doesn't look rusty at all. Thanks so much!