Skip to content

Commit 1faa557

Browse files
Merge pull request #1314 from lukaszstolarczuk/merge-v0.11.x-into-main
Merge v0.11.x into main
2 parents 43d33c2 + 20f5105 commit 1faa557

File tree

3 files changed

+17
-12
lines changed

3 files changed

+17
-12
lines changed

.github/workflows/reusable_gpu.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ jobs:
3939
name: "${{matrix.os}}, ${{matrix.build_type}}, shared=${{matrix.shared_library}}"
4040
env:
4141
VCPKG_PATH: "${{github.workspace}}/build/vcpkg/packages/hwloc_x64-windows;${{github.workspace}}/build/vcpkg/packages/tbb_x64-windows;${{github.workspace}}/build/vcpkg/packages/jemalloc_x64-windows;"
42-
CUDA_PATH: "C:/cuda"
4342
COVERAGE_NAME : "exports-coverage-${{inputs.provider}}-${{inputs.runner}}"
4443
# run only on upstream; forks will not have the HW
4544
if: github.repository == 'oneapi-src/unified-memory-framework'
@@ -52,13 +51,14 @@ jobs:
5251

5352
runs-on: ["DSS-${{inputs.runner}}", "DSS-${{matrix.os}}"]
5453
steps:
55-
# Set number of processes and compiler based on OS
54+
# Set various build params based on OS
5655
- name: "[Win] Establish build params"
5756
if : ${{ matrix.os == 'Windows' }}
5857
run: |
59-
echo "C_COMPILER=cl" >> $GITHUB_ENV
60-
echo "CXX_COMPILER=cl" >> $GITHUB_ENV
61-
echo "PROCS=$Env:NUMBER_OF_PROCESSORS" >> $GITHUB_ENV
58+
echo "C_COMPILER=cl" >> $env:GITHUB_ENV
59+
echo "CXX_COMPILER=cl" >> $env:GITHUB_ENV
60+
echo "PROCS=$Env:NUMBER_OF_PROCESSORS" >> $env:GITHUB_ENV
61+
echo "EXTRA_CMAKE_PATH=$Env:CUDA_PATH" >> $env:GITHUB_ENV
6262
6363
- name: "[Lin] Establish build params"
6464
if : ${{ matrix.os == 'Ubuntu' }}
@@ -93,7 +93,7 @@ jobs:
9393
- name: Configure build
9494
run: >
9595
cmake
96-
-DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}}${{env.CUDA_PATH}}"
96+
-DCMAKE_PREFIX_PATH="${{env.VCPKG_PATH}};${{env.EXTRA_CMAKE_PATH}}"
9797
-B ${{env.BUILD_DIR}}
9898
-DCMAKE_INSTALL_PREFIX="${{env.INSTL_DIR}}"
9999
-DCMAKE_BUILD_TYPE=${{matrix.build_type}}

ChangeLog

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
Mon May 12 2025 Łukasz Stolarczuk <[email protected]>
2+
3+
* Version 0.11.2
4+
5+
This patch release contains following changes:
6+
- retrieve numanode object by os index instead of logical index (#1309)
7+
18
Thu May 08 2025 Łukasz Stolarczuk <[email protected]>
29

310
* Version 0.11.1

src/memtargets/memtarget_numa.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -263,17 +263,15 @@ static umf_result_t query_attribute_value(void *srcMemoryTarget,
263263
return UMF_RESULT_ERROR_NOT_SUPPORTED;
264264
}
265265

266-
hwloc_obj_t srcNumaNode = hwloc_get_obj_by_type(
267-
topology, HWLOC_OBJ_NUMANODE,
268-
((struct numa_memtarget_t *)srcMemoryTarget)->physical_id);
266+
hwloc_obj_t srcNumaNode = hwloc_get_numanode_obj_by_os_index(
267+
topology, ((struct numa_memtarget_t *)srcMemoryTarget)->physical_id);
269268
if (!srcNumaNode) {
270269
LOG_PERR("Getting HWLOC object by type failed");
271270
return UMF_RESULT_ERROR_INVALID_ARGUMENT;
272271
}
273272

274-
hwloc_obj_t dstNumaNode = hwloc_get_obj_by_type(
275-
topology, HWLOC_OBJ_NUMANODE,
276-
((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
273+
hwloc_obj_t dstNumaNode = hwloc_get_numanode_obj_by_os_index(
274+
topology, ((struct numa_memtarget_t *)dstMemoryTarget)->physical_id);
277275
if (!dstNumaNode) {
278276
LOG_PERR("Getting HWLOC object by type failed");
279277
return UMF_RESULT_ERROR_INVALID_ARGUMENT;

0 commit comments

Comments
 (0)