Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate quicker ways to deploy monitoring scripts #271

Closed
FedericoCeratto opened this issue Dec 10, 2019 · 4 comments
Closed

Investigate quicker ways to deploy monitoring scripts #271

FedericoCeratto opened this issue Dec 10, 2019 · 4 comments
Labels
enhancement New feature request or improvement to existing functionality ooni/devops Issues related to https://github.com/ooni/sysadmin priority/low Nice to have

Comments

@FedericoCeratto
Copy link
Contributor

Setting up daemons that write to node_exporter is time consuming

We can test netdata plugins after #268

@SuperQ
Copy link

SuperQ commented Dec 10, 2019

Why not make the daemons that expose Prometheus metrics directly, rather than write out to the node_exporter?

@FedericoCeratto
Copy link
Contributor Author

@SuperQ it would make the daemons significantly more complex, having to run a dedicated thread each to expose the metrics, and more burdensome to deploy, having to assign a unique port to each, allow incoming traffic and configure Prometheus to scrape each of them.
It's difficult to justify when the code doing the real monitoring work is 1 line of bash. (e.g. finding and counting files, running one SQL query, ...)

@SuperQ
Copy link

SuperQ commented Dec 10, 2019

The kinds of monitoring tasks you're talking about are already implemented by good quality code. For example, there are several SQL query exporters for exposing SQL query data.

Add monitoring endpoints to existing daemons is not "significantly more complex". These techniques are well documented and common.

@hellais hellais transferred this issue from ooni/sysadmin Jan 13, 2020
@hellais hellais added effort/M enhancement New feature request or improvement to existing functionality ooni/devops Issues related to https://github.com/ooni/sysadmin priority/low Nice to have labels Jan 13, 2020
@hellais hellais removed the effort/M label Jan 31, 2022
FedericoCeratto pushed a commit that referenced this issue Mar 16, 2023
* Fastpath: Add anomaly and confirmed columns

* Add workaround for CircleCi bug

* Add 019-fastpath-confirmed.rollback.sql

* Add msm_failure column, BRIM index, rename indexes

* Add missing platform UPDATE SET
@hellais hellais moved this to Backlog in Roadmap Jan 27, 2025
@hellais
Copy link
Member

hellais commented Jan 27, 2025

Each service is now exposing metrics directly and we are working toward discontinuing netdata in favour of this. I am closing this issue in favour of the several monitoring related ones we have elsewhere:

@hellais hellais closed this as completed Jan 27, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Roadmap Jan 27, 2025
@hellais hellais moved this from Done to TMP in Roadmap Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement to existing functionality ooni/devops Issues related to https://github.com/ooni/sysadmin priority/low Nice to have
Projects
Archived in project
Development

No branches or pull requests

3 participants