Pylint fixes

Author: Sfonxu

PyMPDATA/solver.py

@@ -56,7 +56,7 @@ def __init__(self):
 
     def call(
         self, traversals_data, flux, g_factor, step, iteration
-    ):  # pylint: disable=unused-argument
+    ):  # pylint: disable=unused-argument,disable=too-many-arguments
         """think of it as a `__call__` method (which Numba does not allow)"""
 
 
@@ -81,11 +81,10 @@ def __init__(
         n_dims = advector.n_dims
         if isinstance(advectee, ScalarField):
             self.__fields = {"advectee": (advectee,)}
-        #    self.advectee = advectee
 
         elif isinstance(advectee, Mapping):
             self.__fields = {"advectee": tuple(advectee.values())}
-        #    advectee = tuple(advectee.values())
+
         elif isinstance(advectee, Iterable):
             self.__fields = {"advectee": tuple(advectee)}
 

scenarios_mpi/_scenario.py

@@ -9,7 +9,7 @@ class _Scenario:  # pylint: disable=too-few-public-methods
     # pylint: disable=too-many-arguments
     def __init__(self, *, mpi_dim, solver=None):
         self.mpi_dim = mpi_dim
-        self.solvers = {"psi": solver}
+        self.solver = solver
 
     def advance(self, dataset, output_steps, mpi_range):
         """Logic for performing simulation. Returns wall time of one timestep (in clock ticks)"""
@@ -21,20 +21,19 @@ def advance(self, dataset, output_steps, mpi_range):
                 wall_time_per_timestep = self._solver_advance(n_steps=n_steps)
                 wall_time += wall_time_per_timestep * n_steps
                 steps_done += n_steps
-            for key in self.solvers.advectee:
-                data = self[key]
+                data = self.solver.advectee.get()
                 dataset[
                     (
                         mpi_range if self.mpi_dim == OUTER else slice(None),
                         mpi_range if self.mpi_dim == INNER else slice(None),
                         slice(index, index + 1),
                     )
                 ] = data.reshape((data.shape[0], data.shape[1], 1))
-                break  # TODO #510: add logic to seperatly read multp. advectees
+                # TODO #510: add logic to seperatly read multp. advectees
         return wall_time
 
     def _solver_advance(self, n_steps):
-        return self.solvers["psi"].advance(n_steps=n_steps)
+        return self.solver.advance(n_steps=n_steps)
 
     def __getitem__(self, _):
-        return self.solvers["psi"].advectee.get()
+        return self.solver.advectee.get()

scenarios_mpi/shallow_water.py

@@ -10,8 +10,7 @@
 from PyMPDATA import ScalarField, Solver, Stepper, VectorField
 from PyMPDATA.boundary_conditions import Periodic
 from PyMPDATA.impl.domain_decomposition import make_subdomain
-from PyMPDATA.impl.enumerations import INNER, MAX_DIM_NUM, OUTER
-from PyMPDATA.impl.formulae_divide import make_divide_or_zero
+from PyMPDATA.impl.enumerations import INNER, OUTER
 from scenarios_mpi._scenario import _Scenario
 
 subdomain = make_subdomain(jit_flags={})
@@ -42,7 +41,6 @@ def initial_condition(x, y, lx, ly):
 
         # pylint: disable=invalid-name
         self.halo = mpdata_options.n_halo
-        n_threads = n_threads
 
         xyi = mpi_indices(grid=grid, rank=rank, size=size, mpi_dim=mpi_dim)
         nx, ny = xyi[mpi_dim].shape