-
Notifications
You must be signed in to change notification settings - Fork 844
ci: enable security checks on push #3151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
90ca86f to
0b72867
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enables security checks to run on pull requests in addition to scheduled runs, likely for testing purposes. The changes include adding a pull_request trigger and modifying the scan configuration to always use full scan settings regardless of trigger type.
Key Changes:
- Added pull_request trigger to enable security scans on PRs (marked as temporary for testing)
- Modified scan parameters to always use comprehensive settings instead of conditional logic
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #DELETE AFTER TESTING | ||
| pull_request: | ||
| #DELETE AFTER TESTING | ||
|
|
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The temporary testing comments should be removed before merging to main. Consider using a feature branch or draft PR status instead of leaving TODO comments in the codebase.
| #DELETE AFTER TESTING | |
| pull_request: | |
| #DELETE AFTER TESTING |
| tools: ${{ 'bandit,clamav,semgrep,trivy,zizmor' || inputs.tools }} | ||
| scan-scope: ${{ 'all' || inputs.scan-scope }} | ||
| severity-level: ${{ 'LOW' || inputs.severity-level }} | ||
| confidence-level: ${{ 'LOW' || inputs.confidence-level }} |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logical OR operator in GitHub Actions expressions doesn't work as intended here. A non-empty string is always truthy, so inputs.tools will never be used. The original conditional logic github.event_name == 'schedule' && 'value' || inputs.value should be restored or replaced with proper conditional logic that accounts for the new pull_request trigger.
| tools: ${{ 'bandit,clamav,semgrep,trivy,zizmor' || inputs.tools }} | |
| scan-scope: ${{ 'all' || inputs.scan-scope }} | |
| severity-level: ${{ 'LOW' || inputs.severity-level }} | |
| confidence-level: ${{ 'LOW' || inputs.confidence-level }} | |
| tools: ${{ github.event_name == 'schedule' && 'bandit,clamav,semgrep,trivy,zizmor' || inputs.tools }} | |
| scan-scope: ${{ github.event_name == 'schedule' && 'all' || inputs['scan-scope'] }} | |
| severity-level: ${{ github.event_name == 'schedule' && 'LOW' || inputs['severity-level'] }} | |
| confidence-level: ${{ github.event_name == 'schedule' && 'LOW' || inputs['confidence-level'] }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mramotowski - could you take a look?
0b72867 to
ea6f587
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlexanderBarabanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Could you trigger scans on PR https://github.com/open-edge-platform/anomalib/pull/3151/checks?
https://github.com/open-edge-platform/anomalib/actions/runs/19728403225/job/56524094782?pr=3151 |
ea6f587 to
14456a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
π‘ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - "bandit,semgrep,trivy,zizmor" | ||
| - "bandit,clamav,semgrep,trivy,zizmor" # Default set |
Copilot
AI
Nov 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment '# Default set' is on line 65, but line 67 shows the actual default is 'bandit,clamav,semgrep,trivy,zizmor'. The comment should be moved to match the default value on line 67 or the comment on line 65 should be removed to avoid confusion.
Signed-off-by: mramotowski <[email protected]>
14456a0 to
1dda80f
Compare
|
Codecov Reportβ All modified and coverable lines are covered by tests. π’ Thoughts on this report? Let us know! |

π Description
β¨ Changes
Select what type of change your PR is:
β Checklist
Before you submit your pull request, please make sure you have completed the following steps:
For more information about code review checklists, see the Code Review Checklist.