Skip to content

Commit b573d80

Browse files
committed
chore: add multi-module compatible Makefile targets
Signed-off-by: Sahid Velji <[email protected]>
1 parent b435fb4 commit b573d80

File tree

5 files changed

+30
-15
lines changed

5 files changed

+30
-15
lines changed

Makefile

Lines changed: 30 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,10 @@ workspace-init:
1010
workspace-update:
1111
$(foreach module, $(ALL_GO_MOD_DIRS), go work use $(module);)
1212

13-
test:
14-
go list -f '{{.Dir}}/...' -m | xargs -I{} go test -v {}
15-
1613
# call with TESTCONTAINERS_RYUK_DISABLED="true" to avoid problems with podman on Macs
1714
e2e:
1815
go clean -testcache && go list -f '{{.Dir}}/...' -m | xargs -I{} go test -tags=e2e {}
1916

20-
lint:
21-
go install -v github.com/golangci/golangci-lint/cmd/[email protected]
22-
$(foreach module, $(ALL_GO_MOD_DIRS), ${GOPATH}/bin/golangci-lint run $(module)/...;)
23-
2417
new-provider:
2518
mkdir ./providers/$(MODULE_NAME)
2619
cd ./providers/$(MODULE_NAME) && go mod init github.com/open-feature/go-sdk-contrib/providers/$(MODULE_NAME) && touch README.md
@@ -34,3 +27,33 @@ new-hook:
3427
append-to-release-please:
3528
jq '.packages += {"${MODULE_TYPE}/${MODULE_NAME}": {"release-type":"go","package-name":"${MODULE_TYPE}/${MODULE_NAME}","bump-minor-pre-major":true,"bump-patch-for-minor-pre-major":true,"versioning":"default","extra-files": []}}' release-please-config.json > tmp.json
3629
mv tmp.json release-please-config.json
30+
31+
.PHONY: go-mod-tidy
32+
go-mod-tidy: $(ALL_GO_MOD_DIRS:%=go-mod-tidy/%)
33+
go-mod-tidy/%: DIR=$*
34+
go-mod-tidy/%:
35+
@echo "go mod tidy in $(DIR)" \
36+
&& cd $(DIR) \
37+
&& go mod tidy
38+
39+
.PHONY: lint
40+
lint: golangci-lint
41+
42+
.PHONY: golangci-lint golangci-lint-fix
43+
golangci-lint-fix: ARGS=--fix
44+
golangci-lint-fix: golangci-lint
45+
golangci-lint: $(ALL_GO_MOD_DIRS:%=golangci-lint/%)
46+
golangci-lint/%: DIR=$*
47+
golangci-lint/%:
48+
@echo 'golangci-lint $(if $(ARGS),$(ARGS) ,)$(DIR)' \
49+
&& cd $(DIR) \
50+
&& go run github.com/golangci/golangci-lint/cmd/[email protected] run --allow-serial-runners $(ARGS)
51+
52+
.PHONY: test
53+
test-verbose: ARGS=-v
54+
test: $(ALL_GO_MOD_DIRS:%=test/%)
55+
test/%: DIR=$*
56+
test/%:
57+
@echo "go test $(ARGS) $(DIR)/..." \
58+
&& cd $(DIR) \
59+
&& go test $(ARGS) ./...

providers/flagd/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module github.com/open-feature/go-sdk-contrib/providers/flagd
22

33
go 1.23.0
44

5-
toolchain go1.24.3
6-
75
require (
86
buf.build/gen/go/open-feature/flagd/connectrpc/go v1.18.1-20250127221518-be6d1143b690.1
97
buf.build/gen/go/open-feature/flagd/grpc/go v1.5.1-20250127221518-be6d1143b690.2

providers/flagsmith/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module github.com/open-feature/go-sdk-contrib/providers/flagsmith
22

33
go 1.22
44

5-
toolchain go1.24.3
6-
75
require (
86
github.com/Flagsmith/flagsmith-go-client/v3 v3.7.0
97
github.com/open-feature/go-sdk v1.11.0

providers/go-feature-flag/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module github.com/open-feature/go-sdk-contrib/providers/go-feature-flag
22

33
go 1.21.0
44

5-
toolchain go1.24.3
6-
75
require (
86
github.com/bluele/gcache v0.0.2
97
github.com/open-feature/go-sdk v1.11.0

providers/launchdarkly/go.mod

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module github.com/open-feature/go-sdk-contrib/providers/launchdarkly
22

33
go 1.23.0
44

5-
toolchain go1.24.3
6-
75
require (
86
github.com/hooklift/assert v0.1.0
97
github.com/launchdarkly/go-sdk-common/v3 v3.1.0

0 commit comments

Comments
 (0)