Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17905: DBT Cloud time format mismatch #17916

Merged
merged 4 commits into from
Sep 23, 2024
Merged

Fixes #17905: DBT Cloud time format mismatch #17916

merged 4 commits into from
Sep 23, 2024

Conversation

aldwyn
Copy link
Contributor

@aldwyn aldwyn commented Sep 19, 2024 •
edited
Loading

Describe your changes:

Fixes #17905

This change the time format of the created_at in dbtcloud metadata from %Y-%m-%dT%H:%M:%S.%f%z to %Y-%m-%d %H:%M:%S.%f%z.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aldwyn aldwyn requested a review from a team as a code owner September 19, 2024 02:54
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@sushi30 sushi30 added safe to test Add this label to run secure Github workflows on PRs Ingestion labels Sep 19, 2024
@sushi30 sushi30 self-assigned this Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 22, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SumanMaharana SumanMaharana merged commit b9f881f into open-metadata:main Sep 23, 2024
13 of 16 checks passed
@SumanMaharana
Copy link
Contributor

@aldwyn Thanks for the fix.

@aldwyn aldwyn deleted the patch-2 branch September 30, 2024 00:40
SumanMaharana added a commit that referenced this pull request Sep 30, 2024
@aldwyn @SumanMaharana
Change time format for the created_at of the DBT cloud pipeline status (
312b584 
#17916)

Co-authored-by: Suman Maharana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SumanMaharana SumanMaharana SumanMaharana approved these changes

@sushi30 sushi30 sushi30 approved these changes

Assignees

@sushi30 sushi30

Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DBT Cloud time format mismatch
3 participants
@aldwyn @SumanMaharana @sushi30