Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Level Zero Sysman Backport for hwloc v2.11 #702

Open
servesh opened this issue Jan 30, 2025 · 6 comments
Open

Level Zero Sysman Backport for hwloc v2.11 #702

servesh opened this issue Jan 30, 2025 · 6 comments

Comments

@servesh
Copy link

servesh commented Jan 30, 2025

Hi, It would be useful to back level zero fixes related to sysman to v2.11 branch. Since there is a dependency on this version and MPICH releases.

I did my best to backport the patches from master to v2.11 branch and tested it on Aurora.
Let me know if a PR on this is helpful or if there are other plans to backport these fixes.

https://github.com/servesh/hwloc/tree/v2.11-level-zero-fix

@bgoglin
Copy link
Contributor

bgoglin commented Jan 30, 2025

Hello. Do you need a proper release, or do you just need a v2.11 branch with those fixes? I am not planning to backport these intrusive changes to an official 2.11.3 but rather release a 2.12 (multiple hurdles have been delaying this release for dumb reasons but hopefully in a couple weeks).

@servesh
Copy link
Author

servesh commented Feb 3, 2025

@bgoglin Its fine if you can include them in the v2.11 branch. We can adopt it in 2.12 whenever its available.

@bgoglin
Copy link
Contributor

bgoglin commented Feb 10, 2025

I pushed a v2.11-mpich branch with 2.11.2 + all backported fixed pending in branch v2.11 + levelzero backports from v2.12. Can you test it?
I am preparing v2.12, rc1 will likely be out tomorrow. Let me know when you start/stop using the v2.11-mpich branch so that I know when you keep/destroy it.

@servesh
Copy link
Author

servesh commented Feb 11, 2025

@bgoglin Thanks. It will take me a few weeks to integrate this into our build/testing at scale. So will take some time to report back. I will continue to use the v2.11-mpich branch until I can confirm that v2.12 works fine with mpich.

@bgoglin
Copy link
Contributor

bgoglin commented Feb 12, 2025

It is ok to rebase this branch when I backport some changes in the official 2.11 ? Or would you rather get merges and fast-forward pulls?

@servesh
Copy link
Author

servesh commented Feb 13, 2025

@bgoglin Rebase or whichever easier is fine. All I'm looking for is a branch/release which has the level zero fixes in hwloc and that works with MPICH. If v2.12 hwloc works with mpich then I wouldn't have to trouble you with maintaining this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants