Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jaeger exporter: default service name typo #1783

Closed
lastchiliarch opened this issue Apr 7, 2021 · 1 comment · Fixed by #1797 · May be fixed by open-o11y/opentelemetry-go#77
Closed

Jaeger exporter: default service name typo #1783

lastchiliarch opened this issue Apr 7, 2021 · 1 comment · Fixed by #1797 · May be fixed by open-o11y/opentelemetry-go#77
Assignees
@humivo
Labels
bug Something isn't working
Milestone
RC1

Comments

@lastchiliarch
Copy link
Contributor

Description

When process the default service name, use the semconv.ServiceVersionKey instead of semconv.ServiceNameKey.

Maybe it's a typo.

opentelemetry-go/exporters/trace/jaeger/jaeger.go

Lines 502 to 507 in e9aaa04

// If no service.name is contained in a Span's Resource,
// that field MUST be populated from the default Resource.
if serviceName.Value.AsString() == "" {
serviceName = semconv.ServiceVersionKey.String(defaultServiceName)
}
process.ServiceName = serviceName.Value.AsString()

Expected behavior

Fix the typo.
@lastchiliarch lastchiliarch added the bug Something isn't working label Apr 7, 2021
@MrAlias MrAlias added this to the RC1 milestone Apr 7, 2021
@humivo
Copy link
Member

humivo commented Apr 7, 2021

I can try to make this small fix! So I just have to change the semconv.ServiceVersionKey to semconv.ServiceNameKey?

This was referenced Apr 9, 2021
Open
Merged
@pellared pellared added this to Go: Bugs Nov 2, 2023
@pellared pellared moved this to Closed in Go: Bugs Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humivo humivo

Labels
bug Something isn't working
Projects
Go: Bugs
Archived in project
Milestone
RC1
3 participants
@lastchiliarch @MrAlias @humivo