Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Clean up charts so it makes sense (sort of) #33

Merged
merged 10 commits into from
Feb 1, 2024
Merged

feat: Clean up charts so it makes sense (sort of) #33

merged 10 commits into from
Feb 1, 2024

Conversation

bdougie
Copy link
Member

@bdougie bdougie commented Jan 30, 2024 •
edited
Loading

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Steps to QA

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify Netlify
Copy link

netlify bot commented Jan 30, 2024 •
edited
Loading

✅ Deploy Preview for contributor-info ready!

Name Link
🔨 Latest commit adde0d1
🔍 Latest deploy log https://app.netlify.com/sites/contributor-info/deploys/65b9d870d5e3b0000839b516
😎 Deploy Preview https://deploy-preview-33--contributor-info.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdougie
Copy link
Member Author

bdougie commented Jan 30, 2024 •
edited
Loading

Currently trying to figure out why the PR list has a random opened PR from November in it.

Screen Shot 2024-01-30 at 3 39 55 PM

https://api.opensauced.pizza/v2/prs/search?status=open&repo=kubernetes%2Fkubernetes&range=30&prev_days_start_date=30&orderBy=created_at

What I am trying to do

Looking to capture the last 30 days on a chart and only the last 30 days. For some reason when fetching data, it always includes a random date. Maybe there is a reason for this, but I am not sure.

@bdougie
Copy link
Member Author

bdougie commented Jan 31, 2024

I did learn a lot about this line chart. It is not that it doesn't respect zeros, it is stacked. I am looking at other ways to display this data now.

Screen Shot 2024-01-30 at 9 00 26 PM

@bdougie bdougie marked this pull request as ready for review January 31, 2024 17:59
@bdougie bdougie changed the title feat: Make charts respect the zero feat: Clean up charts so it makes sense (sort of) Jan 31, 2024
@bdougie bdougie merged commit c16965a into beta Feb 1, 2024
16 checks passed
@bdougie bdougie deleted the zero-based-charts branch February 1, 2024 03:29
open-sauced bot pushed a commit that referenced this pull request Feb 1, 2024
@bdougie @open-sauced
chore(minor): release 1.3.0-beta.1 on beta channel [skip ci]
dc7f074 
## [1.3.0-beta.1](v1.2.1...v1.3.0-beta.1) (2024-02-01)

### 🍕 Features

* Clean up charts so it makes sense (sort of) ([#33](#33)) ([c16965a](c16965a))
open-sauced bot pushed a commit that referenced this pull request Feb 1, 2024
@bdougie @open-sauced
chore(minor): release 1.3.0 [skip ci]
cffd4ec 
## [1.3.0](v1.2.1...v1.3.0) (2024-02-01)

### 🍕 Features

* Clean up charts so it makes sense (sort of) ([#33](#33)) ([c16965a](c16965a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdougie