Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support exporting event_name using OTLP Exporter #3201

Closed
lalitb opened this issue Dec 13, 2024 · 4 comments · Fixed by #3277
Closed

Support exporting event_name using OTLP Exporter #3201

lalitb opened this issue Dec 13, 2024 · 4 comments · Fixed by #3277
Assignees
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@lalitb
Copy link
Member

lalitb commented Dec 13, 2024

As the OTLP Protocol now supports exporting EventName, updates will be needed in the otel-cpp OTLP exporter to include support for exporting EventId::name.

This is placeholder issue, to be implemented once otel-proto 1.5.0 is published

@github-actions github-actions bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 13, 2024
@marcalff marcalff added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 16, 2024
@marcalff
Copy link
Member

opentelemetry-cpp is already upgraded to use opentelemetry-proto 1.15.0.

@marcalff marcalff added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Feb 11, 2025
Copy link

This issue is available for anyone to work on. Make sure to reference this issue in your pull request.
✨ Thank you for your contribution! ✨

@perhapsmaple
Copy link
Contributor

Hi,I would like to work on this. I see that the OTLP Log Recordable already has a method that can be used for this:
void SetEventId(int64_t /* id */, nostd::string_view /* name */) noexcept override;

There is one problem that I can see with this, id is not implemented in the proto. Is it alright to ignore id and set the event_name field?

@lalitb
Copy link
Member Author

lalitb commented Feb 16, 2025

@perhapsmaple thanks for volunteering for this. Yes it should be fine to only populate event_name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants