From 81b24aee9b32f9a3d920c6b96ac2a293526a4b39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Paj=C4=85k?= Date: Wed, 6 Jul 2022 13:57:47 +0200 Subject: [PATCH] Fix minor version for MongoDB integration (#924) --- CHANGELOG.md | 1 + integrations.json | 4 ++-- .../integrations/TestApplication.MongoDB/Program.cs | 8 -------- .../TestApplication.MongoDB.csproj | 1 - 4 files changed, 3 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 025941079e..b338224310 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -58,6 +58,7 @@ This release is built on top of [OpenTelemetry .NET](https://github.com/open-tel - `OTEL_DOTNET_AUTO_INCLUDE_PROCESSES`, - `OTEL_DOTNET_AUTO_EXCLUDE_PROCESSES`, - `OTEL_DOTNET_AUTO_TRACES_DISABLED_INSTRUMENTATIONS`. +- Remove invalid instrumentation for `MongoDB.Driver.Core` <2.3.0. ## [0.1.0-beta.1](https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/releases/tag/v0.1.0-beta.1) diff --git a/integrations.json b/integrations.json index f72da818d9..e1243f5876 100644 --- a/integrations.json +++ b/integrations.json @@ -13,7 +13,7 @@ "MongoDB.Driver.MongoClientSettings" ], "minimum_major": 2, - "minimum_minor": 0, + "minimum_minor": 3, "minimum_patch": 0, "maximum_major": 2, "maximum_minor": 65535, @@ -106,4 +106,4 @@ } ] } -] \ No newline at end of file +] diff --git a/test/test-applications/integrations/TestApplication.MongoDB/Program.cs b/test/test-applications/integrations/TestApplication.MongoDB/Program.cs index 1bca5e23c7..0cf8af5c72 100644 --- a/test/test-applications/integrations/TestApplication.MongoDB/Program.cs +++ b/test/test-applications/integrations/TestApplication.MongoDB/Program.cs @@ -64,9 +64,7 @@ public static void Main(string[] args) Run(collection, newDocument); RunAsync(collection, newDocument).Wait(); -#if MONGODB_2_2 WireProtocolExecuteIntegrationTest(client); -#endif } } @@ -76,7 +74,6 @@ public static void Run(IMongoCollection collection, BsonDocument n using (var syncScope = ActivitySource.StartActivity("sync-calls")) { -#if MONGODB_2_2 collection.DeleteMany(allFilter); collection.InsertOne(newDocument); @@ -107,7 +104,6 @@ public static void Run(IMongoCollection collection, BsonDocument n { Console.WriteLine(document); } -#endif } } @@ -133,7 +129,6 @@ public static async Task RunAsync(IMongoCollection collection, Bso Console.WriteLine(allDocuments.FirstOrDefault()); } } -#if MONGODB_2_2 public static void WireProtocolExecuteIntegrationTest(MongoClient client) { @@ -151,7 +146,6 @@ public static void WireProtocolExecuteIntegrationTest(MongoClient client) channel.KillCursorsAsync(new long[] { 0, 1, 2 }, new global::MongoDB.Driver.Core.WireProtocol.Messages.Encoders.MessageEncoderSettings(), CancellationToken.None).Wait(); } } -#endif private static string Host() { @@ -185,7 +179,6 @@ private static string GetMongoPort(string[] args) } } -#if MONGODB_2_2 #pragma warning disable SA1402 // File may only contain a single type internal class ServerSelector : global::MongoDB.Driver.Core.Clusters.ServerSelectors.IServerSelector { @@ -195,4 +188,3 @@ public IEnumerable SelectServers(ClusterDescription cluster, } } #pragma warning restore SA1402 // File may only contain a single type -#endif diff --git a/test/test-applications/integrations/TestApplication.MongoDB/TestApplication.MongoDB.csproj b/test/test-applications/integrations/TestApplication.MongoDB/TestApplication.MongoDB.csproj index 3abef1bc16..fd2012874f 100644 --- a/test/test-applications/integrations/TestApplication.MongoDB/TestApplication.MongoDB.csproj +++ b/test/test-applications/integrations/TestApplication.MongoDB/TestApplication.MongoDB.csproj @@ -7,7 +7,6 @@ 2.13.1 $(DefineConstants);MONGODB_2_7 - $(DefineConstants);MONGODB_2_2 false