.NET10 CLR changes vs our profiler

[Kielek]

.NET 10 Preview 1 is out.

I have created branch with very based support for .NET10. It passed nuke Workflow on my Win11+Docker for Linux.

I do not see any problem, but new CLR brings 2 important changes:

• Profiler Interest Group - Announcements dotnet/runtime#9305 (comment) - Remove helper method frame from Profiler hooks dotnet/runtime#107152
• Profiler Interest Group - Announcements dotnet/runtime#9305 (comment) - [Profiler] Update GetFunctionInfo2 to have a decent default ClassID dotnet/runtime#107753

Both changes seems to be working fine with out clr-profiler.

Status of the methods mentioned in dotnet/runtime#107152 (comment):

• GetAppDomainsContainingModule
• GetILFunctionBodyAllocator - il_rewriter.cpp
• SetILFunctionBody - il_rewriter.cpp
• SetILInstrumentedCodeMap
• ForceGC
• GetClassFromToken
• GetClassFromTokenAndTypeArgs
• GetFunctionFromTokenAndTypeArgs
• GetAppDomainInfo - clr_helpers.cpp
• RequestReJITWithInliners - commented out in rejit_handles.cpp - RejitHandler::RequestRejit method
• GetReJITIDs
• RequestReJIT - rejit_handles.cpp - RejitHandler::RequestRejit method
• RequestRevert
• EnumJITedFunctions2
• EnumModules
• EnumNgenModuleMethodsInliningThisMethod - rejit_handles.cpp - RejitHandlerModuleMethod::RequestRejitForInlinersInModule method
• ApplyMetaData

[Kielek]

@zacharycmontoya, could you please double check mentioned changes?

[zacharycmontoya]

• Profiler Interest Group - Announcements dotnet/runtime#9305 (comment) - Remove helper method frame from Profiler hooks dotnet/runtime#107152

Yes this one looks fine as it only affects profilers that listen to Enter/Leave function hooks, which we do not use at all, as indicated by us not using SetEnterLeaveFunctionHooks.

• Profiler Interest Group - Announcements dotnet/runtime#9305 (comment) - [Profiler] Update GetFunctionInfo2 to have a decent default ClassID dotnet/runtime#107753

This one also appears fine. There is only one call we make for the affected API GetFunctionInfo2 in continuous_profiler.cpp, and the breaking change only affects the pClassId argument which we do not use.

Overall, LGTM 👍🏼