Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for JDK23 #150

Closed
athre0z opened this issue Sep 10, 2024 · 3 comments · Fixed by #182
Closed

Add support for JDK23 #150

athre0z opened this issue Sep 10, 2024 · 3 comments · Fixed by #182
Assignees
Labels
enhancement New feature or request

Comments

@athre0z
Copy link
Member

athre0z commented Sep 10, 2024

JDK23 is currently in release-candidate status and expected to reach GA on 17th Sep. Attempting to profile it currently results in the following error:

ERRO[1084] Failed to handle new anonymous mapping for PID 2338658: JVM symbol 'CompiledMethod.Sizeof' not found
@athre0z athre0z added the enhancement New feature or request label Sep 10, 2024
@athre0z
Copy link
Member Author

athre0z commented Sep 10, 2024

Probably related:

@athre0z athre0z self-assigned this Sep 10, 2024
@athre0z athre0z removed their assignment Sep 18, 2024
@athre0z
Copy link
Member Author

athre0z commented Sep 20, 2024

I didn't complete this before my last day at Elastic, but my patches for the progress so far live here: athre0z@e25c90d

It seemed to be generally working, though it still needs more testing and probably also some debugging. I had noticed a small percentage of unsymbolized frames.

@fabled fabled self-assigned this Oct 12, 2024
@fabled
Copy link
Contributor

fabled commented Oct 12, 2024

Working on this now, wip tree at https://github.com/fabled/opentelemetry-ebpf-profiler/tree/tt-jdk23

I believe the metadata and immutable data fixup should resolve majority of issue. But will still follow up with further additional comments and documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants