Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For golang go.opentelemetry.io/contrib/config is not an ideal name #5597

Open
bogdandrutu opened this issue May 9, 2024 · 8 comments
Open
Assignees
Labels
area: file-config Related to file-based configuration enhancement New feature or request

Comments

@bogdandrutu
Copy link
Member

config is very generic name and will potentially conflict with lots of other packages. I would recommend using otelconfig for the package if possible.

@jack-berg
Copy link
Member

@codeboten should this be transferred to https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/config?

@codeboten
Copy link
Contributor

codeboten commented May 16, 2024

I don't have permissions to transfer this over to open-telemetry/opentelemetry-go-contrib, maybe a @open-telemetry/go-approvers member can move the issue

@MrAlias MrAlias transferred this issue from open-telemetry/opentelemetry-configuration May 16, 2024
@pellared pellared added area: file-config Related to file-based configuration enhancement New feature or request labels May 17, 2024
@Ali-Alnosairi
Copy link

Is this issue has any problem prevents moving forward with it ?

is it ready to be assigned ?

@MrAlias
Copy link
Contributor

MrAlias commented Sep 12, 2024

I think otelconf should be also be considered.

@mikeblum
Copy link
Contributor

Could I pick this up? otelconf makes sense to me.

@mikeblum
Copy link
Contributor

is this in scope for this refactor?

config: Top-level functions #6602

@pellared
Copy link
Member

is this in scope for this refactor?

config: Top-level functions #6602

No. These are separate issues.

@dmathieu
Copy link
Member

Since this is a published module, we need to ensure we have a deprecated release of the old name, so folks using it now get a warning letting them know they need to change their import paths to keep getting upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: file-config Related to file-based configuration enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants