-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to semconv
for otelmux
#6638
Comments
@martinyonatann @TanishqPorwar : please coordinate among yourselves here and determine how to unify your efforts. Two separate PRs is not a viable solution. Please let me know who this issues should be assigned to. Also, please outline your planned solution prior to any future PRs so we can ensure some level of consensus on the approach. |
@MrAlias Thank you for pointing this out. I had a look at @martinyonatann's PR and noticed that it is quite comprehensive, but it involves implementing separate logic for This reuse aligns with @martinyonatann I’d like to understand your approach better to identify any synergies or areas where we can consolidate efforts. I’m happy to adapt or refine my PR based on our discussion. |
There are two things happening here. The latter is interesting, and makes sense. We should switch otelmux to the semconv package with no new features. Then, we can look into making things better. |
I currently have 3 PRs related to this issue:
These PRs are modular but interrelated. The body wrapper package (PR 1) is a prerequisite for metrics (PR 3). I recommend reviewing and merging them sequentially, starting with PR 1, followed by PR 2, and then PR 3. |
Metrics is a new feature though. So we can ship semconv without it. |
Migrate the otelmux package to generate the
semconv
package, and use it for generating traces and metrics semantic conventions, like theotelhttp
package does.The text was updated successfully, but these errors were encountered: