Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from gRPC message-based instrumentation to transaction-based (streaming) #13368

Open
luke-sterkowicz opened this issue Feb 21, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@luke-sterkowicz
Copy link

Is your feature request related to a problem? Please describe.

We have an endpoint where we return streamed gRPC responses. Turns out there's a separate span created for each message in the stream which leads to sometimes enormous span payloads that depend on the number of streamed results in a short time frame.

Describe the solution you'd like

While there may be reasonable use cases for instrumenting each gRPC response, there should also be a mode where we instrument the gRPC call/transaction as a whole. My request is to add such mode, to be configured by some switch.

Describe alternatives you've considered

No response

Additional context

No response

@luke-sterkowicz luke-sterkowicz added enhancement New feature or request needs triage New issue that requires triage labels Feb 21, 2025
@luke-sterkowicz luke-sterkowicz changed the title Switch from gRPC message-based instrumentation to transaction-bases (streaming) Switch from gRPC message-based instrumentation to transaction-based (streaming) Feb 21, 2025
@breedx-splk breedx-splk removed the needs triage New issue that requires triage label Feb 21, 2025
@breedx-splk
Copy link
Contributor

I'm not entirely sure if there's a spec around this, but I've also heard folks ask for a span attribute to summarize the number of response messages that were streamed. Could be a helpful addition to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants