Skip to content

Missing peer.service in nettyhttpclient service #10361

@vasireddy99

Description

@vasireddy99

Describe the bug

The peer.service is missing in the nettyhttpclient instrumentation of Java Agent v2.0.0. this attribute is only missing in nettyhttpclient instrumentation after upgrading to 2.0, the other http client instrumentations have no issue at the moment.

Steps to reproduce

auto instrumented sample app - netty-http-client-sample-app with the Java agent 2.0

Expected behavior

attributes list should contain peer.service as below.

Note - This below attribute list is from OTel Java agent - v0.32.0(older version).

 Attribute list is: [key: "aws.local.operation"
    value {
      string_value: "GET /fault"
    }
    , key: "aws.local.service"
    value {
      string_value: "aws-appsignals-tests-spring-mvc-client-app"
    }
    , key: "aws.remote.operation"
    value {
      string_value: "GET /backend"
    }
    , key: "aws.remote.service"
    value {
      string_value: "backend:8080"
    }
    , key: "aws.span.kind"
    value {
      string_value: "CLIENT"
    }
    , key: "http.method"
    value {
      string_value: "GET"
    }
    , key: "http.response_content_length"
    value {
      int_value: 0
    }
    , key: "http.status_code"
    value {
      int_value: 500
    }
    , key: "http.url"
    value {
      string_value: "http://backend:8080/backend/fault"
    }
    , key: "net.peer.name"
    value {
      string_value: "backend"
    }
    , key: "net.peer.port"
    value {
      int_value: 8080
    }
    , key: "net.protocol.name"
    value {
      string_value: "http"
    }
    , key: "net.protocol.version"
    value {
      string_value: "1.1"
    }
    , key: "peer.service"
    value {
      string_value: "backend:8080"
    }
    , key: "thread.id"
    value {
      int_value: 29
    }
    , key: "thread.name"
    value {
      string_value: "http-nio-8080-exec-2"
    }
    ]

Actual behavior

peer.service is missing

Attribute list is: [key: "aws.local.operation"
value {
  string_value: "GET /fault"
}
, key: "aws.local.service"
value {
  string_value: "aws-appsignals-tests-netty-http-client-app"
}
, key: "aws.remote.operation"
value {
  string_value: "GET /backend"
}
, key: "aws.remote.service"
value {
  string_value: "backend:8080"
}
, key: "aws.span.kind"
value {
  string_value: "CLIENT"
}
, key: "error.type"
value {
  string_value: "500"
}
, key: "http.request.method"
value {
  string_value: "GET"
}
, key: "http.response.status_code"
value {
  int_value: 500
}
, key: "network.peer.address"
value {
  string_value: "172.18.0.3"
}
, key: "network.peer.port"
value {
  int_value: 8080
}
, key: "network.protocol.version"
value {
  string_value: "1.1"
}
, key: "server.address"
value {
  string_value: "backend"
}
, key: "server.port"
value {
  int_value: 8080
}
, key: "thread.id"
value {
  int_value: 32
}
, key: "thread.name"
value {
  string_value: "nioEventLoopGroup-2-1"
}
, key: "url.full"
value {
  string_value: "http://backend:8080/backend/fault"
}
]

JavaAgent or library instrumentation version

v2.0.0

Environment

JDK:
OS:

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingneeds triageNew issue that requires triage

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions