improve assertions by showing the last result on a timeout #13119
+60
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steverao
reviewed
Jan 29, 2025
testing-common/src/main/java/io/opentelemetry/instrumentation/testing/internal/AwaitUtil.java
Outdated
Show resolved
Hide resolved
steverao
reviewed
Jan 29, 2025
...common/src/main/java/io/opentelemetry/instrumentation/testing/InstrumentationTestRunner.java
Outdated
Show resolved
Hide resolved
|
@steverao can you check again? |
laurit
reviewed
Jan 30, 2025
| @@ -125,12 +126,9 @@ public List<List<SpanData>> waitForTraces(int numberOfTraces) { | |||
| * This waits up to 20 seconds, then times out. | |||
| */ | |||
| public List<LogRecordData> waitForLogRecords(int numberOfLogRecords) { | |||
There was a problem hiding this comment.
Firstly I think you should update the PR title or description to make it easier to understand what you are doing. As far as I can tell the improvement is that you are making metric and log assertion similar to trace assertion.
WDYT about moving the log assertion logic to InstrumentationTestRunner as it is for traces/metrics. Then you would not need the AwaitUtil class and could have the helper method in InstrumentationTestRunner.
There was a problem hiding this comment.
good point @laurit - fixed
zeitlinger
force-pushed
the
await-util
branch
from
1c69808 to
b19f64b
Compare
laurit
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When log and metrics assertions fail, they don't show which assertion actually failed - you just see "timed out" - even the stack trace is lost.
This PR restores the stack trace by running the assertion one last time in the thread of the caller.
In addition, we now also tell the user which metric was not found.