Replies: 1 comment
-
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Summary
The
internal-logsfeature in theopentelemetry-otlpcrate currently enables"opentelemetry-http/internal-logs". However, sinceopentelemetry-httpitself depends on"opentelemetry/internal-logs", this indirection introduces an unnecessary dependency onopentelemetry-httpwhen usinggrpc-tonicwithoutdefaultorhttpfeatures.Current Behavior
In
opentelemetry-otlp/Cargo.toml:This forces users to depend on
opentelemetry-httpeven when:grpc-tonictransporthttpordefaultfeaturesinternal-logsfunctionalityProposed Change
Directly depend on
"opentelemetry/internal-logs"instead:Benefits
Removes forced
opentelemetry-httpdependency forgrpc-tonicusersSince
opentelemetry-httpalready depends onopentelemetry/internal-logs, this change respects the existing dependency chainParticularly for projects using
grpc-tonicwithdefault-features = falseNo breaking changes - all existing functionality preserved
Verification Steps
opentelemetry-http/Cargo.tomlconfirms:opentelemetry-httpAdditional Context
This micro-optimization supports the project's goal of maintaining a lean dependency tree, especially important for users carefully managing their dependency footprint in performance-sensitive applications.
Would you like me to submit a PR for this change?
I can prepare a minimal PR updating the feature flag if the maintainers agree this is a welcome optimization.
cc @lalitb @bantonsson
Beta Was this translation helpful? Give feedback.
All reactions