When creating a request with the POST /request?cmd=create endpoint, an optional review requires a state parameter that is ignored

[oSoMoN]

When using the POST /request?cmd=create API endpoint to create a new request, an optional <review> tag without a state attribute results in an HTTP 400 (bad request).

But if I set the state attribute to a valid value (e.g. "declined"), it is ignored and reset to "new".

Expected result

• If I specify a valid state value, that value should be honoured, not reset to "new".
• I should be able to create a request with a review with no state, and the build service would default it to "new".

[eduardoj]

The state attribute of a review element is ignored by design. See: b15cf19

You can always create a request, and then add reviews.

[oSoMoN]

The state attribute of a review element is ignored by design. See: b15cf19

Ok, so the first point in "Expected result" can be discarded.

What about the second point, i.e. not validating strictly the RNG schema, to allow creating a request containing a review without a state?

[eduardoj]

The state attribute of a review element is ignored by design. See: b15cf19

Ok, so the first point in "Expected result" can be discarded.

👍

What about the second point, i.e. not validating strictly the RNG schema, to allow creating a request containing a review without a state?

That can work, yes.

However, I would be more in favor of following the RNG schema in every case, also for creating a request. I mean, when creating a request, it should be checked that all of its reviews have the state new.