You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
This feature request is related to an issue (P2) that is currently open for the OBS frontend #16911.
As stated in the linked issue, there are inconsistent results querying the GET /source/{prj_name} route on the OBS frontend API side.
In short, there is currently a workaround for this endpoint implemented. By using the query parameter ?deleted=0 we can "force" the OBS frontend API to always pass the request to the backend and answer based on its data. Without ?deleted=0 the response will be send based on frontend DB data.
One of the problems right now with this, there are cases for example with remote projects/interconnect where this leads to inconsistencies as described here #16911 (comment)
Describe the solution you'd like
One suggested solution to avoid inconsistencies here is to simply always let the backend answer #16911 (comment)
This approach is implemented in this PR #16955
The only problem with this right now is that the OBS frontend used to include the count attribute in the directory root tag of the xml response. The backend doesn't.
and simply dropping the count attribute might be an API change that breaks tooling of users.
My suggested solution would be to include the count attribute in the backend xml response for source/:project in order to solve the issue without the introduction of breaking changes on the frontend API.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
This feature request is related to an issue (P2) that is currently open for the OBS frontend #16911.
As stated in the linked issue, there are inconsistent results querying the
GET /source/{prj_name}
route on the OBS frontend API side.In short, there is currently a workaround for this endpoint implemented. By using the query parameter
?deleted=0
we can "force" the OBS frontend API to always pass the request to the backend and answer based on its data. Without?deleted=0
the response will be send based on frontend DB data.One of the problems right now with this, there are cases for example with remote projects/interconnect where this leads to inconsistencies as described here #16911 (comment)
Describe the solution you'd like
One suggested solution to avoid inconsistencies here is to simply always let the backend answer #16911 (comment)
This approach is implemented in this PR #16955
The only problem with this right now is that the OBS frontend used to include the
count
attribute in thedirectory
root tag of the xml response. The backend doesn't.Backend Response:
Frontend Response
This attempt breaks multiple minitests like
open-build-service/src/api/test/functional/source_controller_test.rb
Line 2333 in 827c28f
count
attribute might be an API change that breaks tooling of users.My suggested solution would be to include the
count
attribute in the backend xml response forsource/:project
in order to solve the issue without the introduction of breaking changes on the frontend API.The text was updated successfully, but these errors were encountered: