Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priorities on SMB settings page #1517

Closed
ben80 opened this issue Apr 8, 2023 · 3 comments
Closed

Priorities on SMB settings page #1517

ben80 opened this issue Apr 8, 2023 · 3 comments

Comments

@ben80
Copy link

ben80 commented Apr 8, 2023

I'd like to propose to adjust the description of the SMB settings starting from here (https://androidaps.readthedocs.io/en/latest/Usage/Open-APS-features.html#enable-smb).

  1. Change the order of how the settings are listed to reflect the order on the AAPS screen and the priority of how AAPS handles them
  2. Highlight that "Enable SMB with high temp targets" has the highest priority
  3. Highlight that you can either set "Enable SMB always" or use one or multiple of "Enable SMB with COB", "Enable SMB with temp targets", "Enable SMB after carbs"
@jbfeutz
Copy link
Contributor

jbfeutz commented Jun 29, 2023

#1552

@ben80
Copy link
Author

ben80 commented Nov 5, 2023

I am not sure if some action is expected from me (i am the reporter of this issue).
The issue has been resolved and i support the changes. Thank you.
Am i supposed to close it? This one only or #1552 as well?

@psonnera
Copy link
Collaborator

@ben80 as far as I can see this has been worked on. Can you confirm it matches your request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants