-
-
Notifications
You must be signed in to change notification settings - Fork 19
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
ACP spec defines thought_level as a standard SessionConfigOptionCategory for controlling reasoning/thinking levels. However, codex-acp (v0.9.3) doesn't implement session/set_config_option yet — it returns -32602 Invalid params.
Goal
Make acpx codex set <configId> <value> work for controlling thinking/reasoning level when using codex.
Options
- Upstream fix: contribute
session/set_config_optionsupport to codex-acp (@zed-industries/codex-acp) - Workaround: if codex-acp exposes thinking via CLI flags or env vars, pass them at agent spawn time instead of through ACP config
- Graceful fallback: improve acpx error handling so
setreturns a clear message when the agent doesn't support config options (instead of[object Object])
Context
- ACP spec:
SessionConfigOptionCategoryincludesthought_level - codex-acp returns JSON-RPC
-32602forsession/set_config_option session/set_modealso returns-32602(same root cause — codex-acp doesn't implement these methods)- acpx already has the client-side plumbing:
acpx codex set <key> <value>andacpx codex set-mode <mode>
Related
- Discovered during manual testing of full ACP coverage (PR fix: cancel prompt during startup #10)
- JSON-RPC error wrapping bug (raw
{code, message}objects instead of Error instances) should also be fixed
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request