Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve/toos-v2]: add check-consistency #2351

Open
Cyber-SiKu opened this issue Mar 30, 2023 · 8 comments
Open

[curve/toos-v2]: add check-consistency #2351

Cyber-SiKu opened this issue Mar 30, 2023 · 8 comments
Labels
enhancement improve feature good first issue Good for newcomers OSPP2023 开源之夏2023(https://summer-ospp.ac.cn)

Comments

@Cyber-SiKu
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support bs check consistency command in curve tool

  • The implementation of the old tool is here:
    int ConsistencyCheck::CheckFileConsistency(const std::string& fileName,
    bool checkHash) {
    std::set<CopySet> copysets;
    int res = FetchFileCopyset(fileName, &copysets);
    if (res != 0) {
    std::cout << "FetchFileCopyset of " << fileName << " fail!"
    << std::endl;
    return -1;
    }
    for (auto copyset : copysets) {
    res = CheckCopysetConsistency(copyset, checkHash);
    if (res != 0) {
    std::cout << "CheckCopysetConsistency fail!" << std::endl;
    return -1;
    }
    }
    std::cout << "consistency check success!" << std::endl;
    return 0;
    }
  • The old command input and out put:
curve_ops_tool check-consistency -filename=/test

-------
output:

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

Describe the solution you'd like (描述你期望的解决方法)

Add subcommand clinet to curve bs list.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@Cyber-SiKu Cyber-SiKu added the enhancement improve feature label Mar 30, 2023
@Cyber-SiKu Cyber-SiKu added the OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) label Apr 7, 2023
@Cyber-SiKu
Copy link
Contributor Author

Someone has done some work in this pr, you can refer to it.

@Cyber-SiKu Cyber-SiKu added OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) and removed OSPP2023 开源之夏2023(https://summer-ospp.ac.cn) labels Apr 7, 2023
@lng2020
Copy link
Contributor

lng2020 commented Apr 15, 2023

@Cyber-SiKu Can I work on this issue? I have already completed the curve bs clean-recycle issue assigned to me (the PR is here). I would like to have it as my OSPP 2023 program.

@TimePrinciple
Copy link

Hello, mentor @Cyber-SiKu. I've done some analysis and study on this issue, and formed a proposal. It would be much appreciated if you could choose me to complete this assignment.

@Cyber-SiKu
Copy link
Contributor Author

@lng2020 Sorry, this topic has been claimed by others, Curve's OSPP2023 should have other topic, can you go and have a look?

@wuhongsong
Copy link
Contributor

@Cyber-SiKu

@Cyber-SiKu
Copy link
Contributor Author

Hello, mentor @Cyber-SiKu. I've done some analysis and study on this issue, and formed a proposal. It would be much appreciated if you could choose me to complete this assignment.

Sorry, I confused you with the last person, are you a student? You can send me your proposals and I'll evaluate them and choose one from you.

@caoxianfei1
Copy link
Contributor

@TimePrinciple

@ilixiaocui ilixiaocui added the good first issue Good for newcomers label Jun 9, 2023
@ilixiaocui
Copy link
Contributor

ilixiaocui commented Jun 9, 2023

this topic is in Curve's OSPP2023 and has passed the registration phase.

welcome to pay attention to other good first issues .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature good first issue Good for newcomers OSPP2023 开源之夏2023(https://summer-ospp.ac.cn)
Projects
None yet
Development

No branches or pull requests

6 participants