Skip to content

feat: Edit team member modal#137

Merged
diana-villalvazo-wgu merged 3 commits intoopenedx:mainfrom
WGU-Open-edX:105/edit-member
Apr 20, 2026
Merged

feat: Edit team member modal#137
diana-villalvazo-wgu merged 3 commits intoopenedx:mainfrom
WGU-Open-edX:105/edit-member

Conversation

@diana-villalvazo-wgu
Copy link
Copy Markdown
Contributor

@diana-villalvazo-wgu diana-villalvazo-wgu commented Mar 18, 2026 •
edited
Loading

Description

Edit team member modal

Supporting information

Closes #105

Testing instructions

Screenshot

Screenshot 2026-04-17 at 1 10 36 p m

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 18, 2026
@openedx-webhooks
Copy link
Copy Markdown

openedx-webhooks commented Mar 18, 2026 •
edited
Loading

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.81%. Comparing base (166de76) to head (313ab1f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   86.25%   86.81%   +0.55%     
==========================================
  Files         124      126       +2     
  Lines        1732     1797      +65     
  Branches      352      387      +35     
==========================================
+ Hits         1494     1560      +66     
+ Misses        232      229       -3     
- Partials        6        8       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Mar 23, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 23, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 105/edit-member branch 2 times, most recently from 21c65b5 to a8ec0eb Compare April 9, 2026 23:07
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 105/edit-member branch 4 times, most recently from e3b0fcb to c0126df Compare April 16, 2026 19:42
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review April 16, 2026 19:46
@diana-villalvazo-wgu diana-villalvazo-wgu changed the title Edit team member modal feat: Edit team member modal Apr 16, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 105/edit-member branch 3 times, most recently from d44cf81 to 9ca11d7 Compare April 17, 2026 17:58
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Apr 17, 2026
jesusbalderramawgu
jesusbalderramawgu reviewed Apr 17, 2026
View reviewed changes
Comment thread src/courseTeam/components/EditTeamMemberModal.tsx Outdated
jesusbalderramawgu
jesusbalderramawgu reviewed Apr 17, 2026
View reviewed changes
Comment thread src/courseTeam/components/EditTeamMemberModal.tsx Outdated
jesusbalderramawgu
jesusbalderramawgu reviewed Apr 17, 2026
View reviewed changes
Comment thread src/courseTeam/components/EditTeamMemberModal.tsx Outdated
jesusbalderramawgu
jesusbalderramawgu reviewed Apr 17, 2026
View reviewed changes
Comment thread src/courseTeam/components/MembersContent.tsx Outdated
jesusbalderramawgu
jesusbalderramawgu approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@jesusbalderramawgu jesusbalderramawgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments, LGTM!

wgu-jesse-stewart
wgu-jesse-stewart requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. A few minor nitpicks and 1 concern about race conditions

Comment thread src/courseTeam/components/EditTeamMemberModal.tsx Outdated
Comment thread src/courseTeam/components/RoleFilter.tsx Outdated
Comment thread src/courseTeam/types.ts
wgu-jesse-stewart
wgu-jesse-stewart approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thank you

@diana-villalvazo-wgu diana-villalvazo-wgu merged commit 77d16f0 into openedx:main Apr 20, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions Apr 20, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the 105/edit-member branch April 20, 2026 21:19
@openedx-semantic-release-bot
Copy link
Copy Markdown

openedx-semantic-release-bot commented Apr 20, 2026

🎉 This PR is included in version 1.0.0-alpha.14 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wgu-jesse-stewart wgu-jesse-stewart wgu-jesse-stewart approved these changes

+1 more reviewer

@jesusbalderramawgu jesusbalderramawgu jesusbalderramawgu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ticket - Edit Team Member Modal

6 participants

@diana-villalvazo-wgu @openedx-webhooks @openedx-semantic-release-bot @wgu-jesse-stewart @jesusbalderramawgu @mphilbrick211