-
Notifications
You must be signed in to change notification settings - Fork 5
style: update code to use Typescript as type checker #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
=======================================
Coverage 90.74% 90.74%
=======================================
Files 48 48
Lines 4389 4389
Branches 271 271
=======================================
Hits 3983 3983
Misses 317 317
Partials 89 89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8b339d2 to
f72c963
Compare
f72c963 to
5f3adc9
Compare
Henrrypg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes if applies. It worked pretty fine in my local and all changes makes sense to me. LGTM
frontend/src/services/index.ts
Outdated
| getDefaultEndpoint, | ||
| formatErrorMessage, | ||
| mergeProps, | ||
| } from './utils'; No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing end blank line here
frontend/tsconfig.json
Outdated
| "plugins/**/*" | ||
| ], | ||
| "exclude": ["dist", "node_modules"] | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is autogenerated? if not maybe we need end blankline here too
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dcoa for the fixes. Exactly this kind of thing is what I wanted to know from a real frontend dev.
I added the ts files to linting and applied the fixes suggested by henrry. If you are good with this let me know and I'll merge
|
Excellent @felipemontoya, thank you for the review and the fixes, we can merge this one. |
Description
This PR replaces PropTypes with TypeScript to improve type checking in the frontend code. The reasoning behind this change is that PropTypes was marked as deprecated in 2015 and was fully removed in React 19. As a replacement, React and Open edX (OEP-67) recommend using TypeScript.
What this PR does:
What this PR does not do: