Skip to content

Commit 7fff5e1

Browse files
fix: Apply suggestions from code review
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
1 parent 978d760 commit 7fff5e1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

openedx/core/djangoapps/notifications/base_notification.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ class NotificationType(TypedDict):
2525
notification_app: str
2626
# Unique identifier for this notification type.
2727
name: str
28-
# Mark this as a use_app_defaults notification.
28+
# Whether this notification type uses the notification app's default settings.
2929
# When True, user preferences are taken from the notification app's configuration,
3030
# overriding the `web`, `email`, `push`, `email_cadence`, and `non_editable` attributes set here.
3131
use_app_defaults: bool
@@ -386,7 +386,7 @@ def get_notification_content(notification_type: str, context: dict[str, Any]):
386386
if notification_type == 'course_update':
387387
notification_type = 'course_updates'
388388

389-
# Retrieve the notification type object from NotificationTypeManager.
389+
# Retrieve the notification type object from the default preferences (derived from COURSE_NOTIFICATION_TYPES).
390390
notification_type = get_default_values_of_preferences().get(notification_type, None)
391391

392392
if notification_type:

0 commit comments

Comments
 (0)