-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Description
Ticket : openedx/openedx-platform#37947
This pull request refactors and simplifies the notification preferences system in the openedx/core/djangoapps/notifications module. It removes the NotificationTypeManager and NotificationAppManager classes, consolidates logic for retrieving notification preferences, and updates related documentation and function usage. The main goal is to streamline how default notification preferences are accessed and managed, reducing complexity and improving maintainability.
Key changes include:
Refactoring and Simplification:
- Remove
v2/configurationsnotifications API - Removed the
NotificationTypeManagerandNotificationAppManagerclasses, along with their methods for managing notification types and preferences, in favor of a simpler, function-based approach. - Deleted the
get_default_values_of_preferencefunction and replaced its usage with the more generalget_default_values_of_preferencesfunction throughout the codebase.
Documentation and Naming Updates: - Updated docstrings and comments to clarify that
use_app_defaultsreplaces the previous concept of "core" notifications, improving terminology and developer understanding.
Code Cleanup: - Removed the unused
get_non_editable_channelsfunction from the serializers, further reducing unnecessary code. - Cleaned up test imports by removing references to deleted classes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done