Skip to content

Commit 53c1710

Browse files
author
Adam Bradley
committed
fix(content): scroll=false in sidemenu hides content
Closes ionic-team#1485
1 parent 8da9f34 commit 53c1710

File tree

4 files changed

+9
-1
lines changed

4 files changed

+9
-1
lines changed

demos/directive/sideMenus/navWithMenu/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<header class="bar bar-header bar-stable">
2020
<h1 class="title">Left</h1>
2121
</header>
22-
<ion-content class="has-header">
22+
<ion-content class="has-header" scroll="false">
2323
<ion-list>
2424
<ion-item nav-clear menu-close href="#/app/search">
2525
Search

js/angular/directive/content.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ function($timeout, $controller, $ionicBind) {
5858
innerElement = jqLite('<div class="scroll"></div>');
5959
innerElement.append(element.contents());
6060
element.append(innerElement);
61+
} else {
62+
element.addClass('scroll-content-false');
6163
}
6264

6365
return { pre: prelink };

scss/_scaffolding.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,10 @@ body.grade-c {
6969
height: auto;
7070
}
7171

72+
.scroll-content-false {
73+
z-index: $z-index-scroll-content-false;
74+
}
75+
7276
.scroll-view {
7377
position: relative;
7478
display: block;

scss/_variables.scss

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -673,10 +673,12 @@ $z-index-modal: 10 !default;
673673
$z-index-pane: 1 !default;
674674
$z-index-popup: 12 !default;
675675
$z-index-scroll-bar: 9999 !default;
676+
$z-index-scroll-content-false: 10 !default;
676677
$z-index-slider-pager: 1 !default;
677678
$z-index-tabs: 5 !default;
678679
$z-index-view: 1 !default;
679680

681+
680682
// Platform
681683
// -------------------------------
682684

0 commit comments

Comments
 (0)