-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessibility improvements on fun mooc and richie #27
Comments
ping @sampaccoud @jbpenrath |
About tarteaucitron, we talked about orejime. Do you think this library addresses all issues you mentionned about tarteaucitron ? |
Those specific issues are indeed fixed with orejime. But I feel like switching the whole consent manager is kinda overkill here, after looking at the code, tarteaucitron is pretty great a11y-wise, those couple issues are easily fixed with small CSS changes. |
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. A good takeoff seems to use the "silver" color which fulfill RGAA contrast criteria and is dark enough to understand that something is "disabled". Related issue : #27
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. It appears that currently a light color on a tealish background does not comply at all with RGAA! The only color that could be used is black. But currently, all text in the course subheader is white so if we use a black color for this label only we are breaking ui consistency. In other hand, the new constrast color norm used by the WCAG next version 3, APCA challenge in this case. It appears that a pale-grey 16px bold text on a tealish background could comply with APCA. So as a take-off, in order to improve accessibility and keep ui consistency, we could use a 'pale-grey' color for this label. When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. A good takeoff seems to use the "silver" color Related issue : #27
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. It appears that currently a light color on a tealish background does not comply at all with RGAA! The only color that could be used is black. But currently, all text in the course subheader is white so if we use a black color for this label only we are breaking ui consistency. In other hand, the new constrast color norm used by the WCAG next version 3, APCA challenge in this case. It appears that a pale-grey 16px bold text on a tealish background could comply with APCA. So as a take-off, in order to improve accessibility and keep ui consistency, we could use a 'pale-grey' color for this label. Related issue : #27
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. It appears that currently a light color on a tealish background does not comply at all with RGAA! The only color that could be used is black. But currently, all text in the course subheader is white so if we use a black color for this label only we are breaking ui consistency. In other hand, the new constrast color norm used by the WCAG next version 3, APCA, challenges RGAA in this case. It appears that a pale-grey 16px bold text on a tealish background could comply with APCA. So as a take-off, in order to improve accessibility and keep ui consistency, we could use a 'pale-grey' color for this label. Related issue : #27
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. A good takeoff seems to use the "silver" color which fulfill RGAA contrast criteria and is dark enough to understand that something is "disabled". Related issue : #27
When no opened course runs are available, a label is displayed to explain that to the user but currently the shade difference between the color label and its background does not comply with RGAA. It appears that currently a light color on a tealish background does not comply at all with RGAA! The only color that could be used is black. But currently, all text in the course subheader is white so if we use a black color for this label only we are breaking ui consistency. In other hand, the new constrast color norm used by the WCAG next version 3, APCA, challenges RGAA in this case. It appears that a pale-grey 16px bold text on a tealish background could comply with APCA. So as a take-off, in order to improve accessibility and keep ui consistency, we could use a 'pale-grey' color for this label. Related issue : #27
Here a few things I noted that we can still do on fun-mooc/richie:
Links (fun-mooc)
Content links are, for now, only differentiated by color. Accessibility-wise, this is OK as long as:
For now the contrast ratio is not high enough (2.86:1 between the red links and the black body text around them).
My advice would be to have the links be underlined by default. This allows us to keep the brand color on them.
Navigation menu (fun-mooc)
On fun-mooc's homepage, a few menu items have color issues because of the background. One solution would be to add a white background on menu items.
Course detail block (fun-mooc and richie)
aria-label
attribute on each<a>
that is the same as itstitle
attribute. We must do this because thetitle
attribute is not necessarily announced by screen readers.Tarteaucitron (fun-mooc)
A couple things should be improved in the tarteaucitron dialog:
Accesskeys (richie)
Two anchors have an
accesskey
attribute. This seems like a good idea at first but it's not really recommended to use them. A few reasons to that: there can be conflicts with browser shortcuts, screen reader shortcuts, they are not configurable by the user.So here the fix would be to simply remove the
accesskey
attributes.Cleaning a few content plugins (richie)
While I thought I went through all the available plugins on the website, I was wrong…
There are still a few problems here and there with some plugins. We can note the quote plugin, the license plugin…
Refer to the accessibility docs to check for issues. Most of issues related to plugins already fixed were:
<a>
wrapping rich contentObsolete HTML tags generated by the CMS
The CMS generates some presentation-only HTML tags that should be avoided, mainly the
<big>
tag. They generate errors in the W3C validator, making the RGAA criterion 8.2 fail, and since they are presentation-only tags, they make the RGAA criterion 10.1 fail. In terms of actual real accessibility issues, we could argue this has no real impact, really… so that's a bit of annoying things to do to make WCAG happy.Item lists (optional) (richie)
In a lot of pages, we list different kind of resources: subjects, collections, organizations, courses, persons… For now most of those lists are packs of
div
.We can argue the better thing to do would be to wrap those lists in
<ul>
and<li>
tags, as they are actual lists of items. Doing so would help a tiny bit screen reader users by giving them an alternative way to navigate through these items (via list-related keyboard shortcuts) and get more context.This is not a deal-breaker though. Content is accessible, and screen reader users can navigate from item to item by using headings-specific shortcuts.
The text was updated successfully, but these errors were encountered: