Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase minimum deployment target to 9.0 #601

Closed
smamczak opened this issue Oct 23, 2020 · 9 comments · Fixed by #690
Closed

Increase minimum deployment target to 9.0 #601

smamczak opened this issue Oct 23, 2020 · 9 comments · Fixed by #690

Comments

@smamczak
Copy link

Describe the bug
I gen this warning message:
The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

To Reproduce
Add library via SPM and compile

Expected behavior
No warnings

@JackoPlane
Copy link

👍

@chrismash2
Copy link

Agree that this should be updated in the AppAuth project, but for now (and for other pods that give you the same warning) you could do what I did and suppress the warnings from the pods:

Add this at the top-ish of your Podfile:

$minVersion='11.0'
inhibit_all_warnings!

You can use that $minVersion parameter in your target blocks like so:

platform :ios, $minVersion

Add this post-install script at the bottom of your Podfile to avoid the reported warning:

# Post-install script
post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      # Avoid warnings of pods having a lower deployment target by overriding it to our minimum
      if Gem::Version.new($minVersion) > Gem::Version.new(config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'])
        config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = $minVersion
      end
    end
  end
end

The inhibit_all_warnings! added to the top of the Podfile is useful in case raising the min version causes more warnings (like deprecation warnings or other warnings not related to the min version) to be reported from the pod after bumping its min version.

@JackoPlane
Copy link

Unfortunately I haven't been able to find a similar way to suppress these warnings from SPM modules

@smamczak
Copy link
Author

smamczak commented Nov 2, 2020

I second that. If you already support SPM then please raise the target since Apple will stop accepting apps below 9.0 SDK

@davbeck
Copy link
Contributor

davbeck commented Nov 30, 2020

#604 should fix this for SPM in a way that maintains compatibility with older versions of Xcode.

@guigoruiz1
Copy link

Same problem here. Please raise the target version

@iGriever
Copy link

Any updates on this? The new GoogleSignIn SDK (with SPM and Apple Silicon support) has AppAuth as a dependency, which raises this warning.

@smamczak
Copy link
Author

Any updates for SPM?

@smamczak
Copy link
Author

Please fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants