-
Notifications
You must be signed in to change notification settings - Fork 324
7904059: Enable alternative Runner instantiation and Main reuse #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
|
@galderz This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/touch |
|
@galderz The pull request is being re-evaluated and the inactivity timeout has been reset. |
This is the third in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.
This PR refactors the main class to enable reuse of most of its logic, while allowing the construction of the
Runnerinstance to be overridden by a subclass. An example of this override can be seen here.Here is the PR list for reference:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/161/head:pull/161$ git checkout pull/161Update a local copy of the PR:
$ git checkout pull/161$ git pull https://git.openjdk.org/jmh.git pull/161/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 161View PR using the GUI difftool:
$ git pr show -t 161Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/161.diff
Using Webrev
Link to Webrev Comment