-
Notifications
You must be signed in to change notification settings - Fork 324
adding the missing directive -proc:full #164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…: /META-INF/benchmark List" when generating a jmh project using jmh-java-benchmark-archetype
|
Hi @Arcane561, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user Arcane561" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
|
❗ This change is not yet ready to be integrated. |
|
To avoid this situation, create a new branch for your changes and reset the Then proceed to create a new pull request with |
|
@Arcane561 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
This one is not needed, as the block |
|
Good day to you, Alexey. You may be right, but bootstrapping the test via no longer works if you don't add it manually |
Error correction when running
ERROR: Unable to find the resource: /META-INF/benchmark Listwhile generating a jmh project using the jmh-java-benchmark-archetype.added directive -proc:full in java maven archetype, without which the assembled benchmark project does not start
error:
This error has already been reported here.
https://mail.openjdk.org/pipermail/jmh-dev/2023-October/003811.html
it is also described in
https://stackoverflow.com/a/79096948
and it seems to be present since jdk 22.
Progress
Error
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/164/head:pull/164$ git checkout pull/164Update a local copy of the PR:
$ git checkout pull/164$ git pull https://git.openjdk.org/jmh.git pull/164/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 164View PR using the GUI difftool:
$ git pr show -t 164Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/164.diff