fixup! use the current platform for --os in dev

Author: vicb

README.md

@@ -98,7 +98,28 @@ To run `OpenNext` locally:
 
 There is also a way to run OpenNext locally. You can read a guide about it [here](https://opennext.js.org/aws/contribute/local_run). Its mostly used for development/debugging purposes.
 
-### Coldstart
+## Testing
+
+You can run unit tests with
+
+```bash
+pnpm test
+```
+
+You can tun e2e locally with:
+
+```bash
+pnpm -r openbuild:local
+pnpm -r openbuild:local:start
+```
+
+And in a different shell:
+
+```bash
+pnpm e2e:test
+```
+
+## Coldstart
 
 OpenNext provide you with a warmer function that can be used to reduce cold start.
 

packages/open-next/src/build/createImageOptimizationBundle.ts

@@ -1,5 +1,6 @@
 import fs from "node:fs";
 import { createRequire } from "node:module";
+import os from "node:os";
 import path from "node:path";
 
 import logger from "../logger.js";
@@ -112,12 +113,17 @@ export async function createImageOptimizationBundle(
 
   const sharpVersion = process.env.SHARP_VERSION ?? "0.32.6";
 
+  // In development, we want to use the local machine settings
+  const isDev = config.imageOptimization?.loader === "fs-dev";
+
   installDependencies(
     outputPath,
     config.imageOptimization?.install ?? {
       packages: [`sharp@${sharpVersion}`],
-      // By not specifying an arch, `npm install` will choose one for us (i.e. our system one)
-      arch: config.imageOptimization?.loader === "fs-dev" ? undefined : "arm64",
+      // By not specifying an arch in dev, `npm install` will choose one for us (i.e. our system one)
+      arch: isDev ? undefined : "arm64",
+      // Use the local platform in dev
+      os: isDev ? os.platform() : "linux",
       nodeVersion: "18",
       libc: "glibc",
     },

packages/open-next/src/build/installDeps.ts

@@ -34,9 +34,10 @@ export function installDependencies(
     const libcOption = installOptions.libc
       ? `--libc=${installOptions.libc}`
       : "";
+    const osOption = installOptions.os ? `--os=${installOptions.os}` : "linux";
 
     const additionalArgs = installOptions.additionalArgs ?? "";
-    const installCommand = `npm install --os=linux ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`;
+    const installCommand = `npm install ${osOption} ${archOption} ${targetOption} ${libcOption} ${additionalArgs} ${installOptions.packages.join(" ")}`;
     execSync(installCommand, {
       stdio: "pipe",
       cwd: tempInstallDir,

packages/open-next/src/types/open-next.ts

@@ -296,18 +296,15 @@ export interface InstallOptions {
    * ```
    */
   packages: string[];
-  /**
-   * @default undefined
-   */
+  /** @default undefined */
   arch?: "x64" | "arm64";
-  /**
-   * @default undefined
-   */
+  /** @default undefined */
   nodeVersion?: string;
-  /**
-   * @default undefined
-   */
+  /** @default undefined */
   libc?: "glibc" | "musl";
+  /** @default "linux" */
+  os?: string;
+
   /**
    * @default undefined
    * Additional arguments to pass to the install command (i.e. npm install)