-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display and color code readings on the map #237
Comments
I'm not sure an entirely new classification system is necessary but I like the idea of challenging the limitations of existing classifications. When we're ready to dig into this, we should also be sure to center the conversation around the work WOEIP has already done here—they already have a set of actual environmental indicators (pdf attached, pp13-19). We'll want to explore what a classification system implies:
etc. |
Per our conversation with him, Brian's recommendation is to use the 24 hr average EPA color standard for PM2.5 for our air quality readings on the map (source) I think everything Jess mentioned above are still good things we should consider at some point. However, for the MVP let's stick with Brian's recommendation and use a standard for a 24 hour average even though woaq's air quality numbers for a single session (and even the comparison of sessions) are computed with real time data. |
@brooksjessup is working on the color coding with @kbrdsk, so I assigned both of them to this one. Since this is a larger ticket, we may end up having several assignees. |
I see the third acceptance criteria: "see the min or max of air quality per 3 meters" used to be its own issue- #315 . I think it should be split back into its own issue for three reasons.
|
@theecrit tagging you for the comment above as I'm not sure if Github sent the notification due to some formatting issue I had when I first posted the comment. |
Shoot @TangoYankee -- sorry, I should have made this more obvious on the ticket itself as opposed to just it being a comment but Brooks and Kabirdas actually implemented #2 in Mapbox itself! Kabirdas opened up PR #364 so that we could do stylings in Mapbox (and also use the one Brooks already created for #2, check it out here) that would show up on the website. However, being that I'm not a web developer myself, I'm not sure if it's better to have it done on Mapbox and use Kabirdas' code to have it show up on the app, or to do it through React (as I'm guessing you did?). Anyway, sorry for this situation where we have two solutions for the same problem! |
Having the feature depend on an outside style is fragile. If the map breaks or we need to change it, it is difficult or impossible for another developer to manage it. The application is designed to use react and mapbox directly in the front end. This allows any developer to have direct access to how the data is displayed. It also gives us more control to optimize its performance and add new features, such as #331 . |
I went ahead and moved the third item into #315; thanks for your patience!
Sorry @TangoYankee, I misspoke back when I wrote this comment. #2 does have a design (as you've already implemented). The dot representing the reading along the path should take on the color of the max reading.
|
Are you referring to the pop-up for an individual geolocation? That is covered by #331 and is not within the scope of this issue, so shouldn't be a blocker. This issue is for the route path display only. |
@theecrit -- you're totally right, and I finally got around to updating the comment above. Sorry for the confusion! |
@mnorelli, Tim actually has a PR open for this work! #380 I'm going to take you off as an assignee for this ticket since Tim completed it, but I added you as a reviewer to the PR as I thought you'd be a great person to do it! Hopefully this is okay with you, but take yourself as an assignee if not. (Apologies that I didn't realize this work was already done 😅 ) |
Description
The viewer wants to look at the data points displayed on a map and understand at a glance what the general degree of pollution is for those locations.
Technical implications and resources
Archived issue description for posterity
Is your feature request related to a problem? Please describe.
AQ Data for PM2.5 particulate matter are collected as an absolute measurement of
Parts Per Millionmilligrams per cubic meter or micrograms per cubic meter. There should be a classification system in order to provide context to how dangerous the air was during a sessionDescribe the solution you'd like
There should be an algorithm / set of rules to classify the AQ. The rules should be open source, to give users a way of challenging the assumption we made in developing the rules. The rules should reflect best practices for Public Health.
Describe alternatives you've considered
Instead of a classification system, we could present raw statistics, such as min, max, mean, median, and st dev of readings.
Additional context
This classification system should provide users a quick way to accurately gauge the danger posed by air pollution.
Existing classification systems
@gsehrlich edited information about units in which data are collected on 5/3/2022. See issue #464.
The text was updated successfully, but these errors were encountered: