Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display and color code readings on the map #237

Closed
2 tasks
TangoYankee opened this issue Aug 2, 2020 · 16 comments · Fixed by #380
Closed
2 tasks

Display and color code readings on the map #237

TangoYankee opened this issue Aug 2, 2020 · 16 comments · Fixed by #380
Assignees
Labels
component: user interface feature: map milestone: MVP Required to ship status: ready to work on Prioritized and ready for a contributor to move to "In Progress"

Comments

@TangoYankee
Copy link
Member

TangoYankee commented Aug 2, 2020

Description

The viewer wants to look at the data points displayed on a map and understand at a glance what the general degree of pollution is for those locations.

Technical implications and resources


Archived issue description for posterity

Is your feature request related to a problem? Please describe.
AQ Data for PM2.5 particulate matter are collected as an absolute measurement of Parts Per Million milligrams per cubic meter or micrograms per cubic meter. There should be a classification system in order to provide context to how dangerous the air was during a session

Describe the solution you'd like
There should be an algorithm / set of rules to classify the AQ. The rules should be open source, to give users a way of challenging the assumption we made in developing the rules. The rules should reflect best practices for Public Health.

Describe alternatives you've considered
Instead of a classification system, we could present raw statistics, such as min, max, mean, median, and st dev of readings.

Additional context
This classification system should provide users a quick way to accurately gauge the danger posed by air pollution.

Existing classification systems


@gsehrlich edited information about units in which data are collected on 5/3/2022. See issue #464.

@TangoYankee TangoYankee added status: needs definition Issue needs more info to be ready to work on status: backlog Issue is not ready to be worked on. component: user interface labels Aug 2, 2020
@theecrit
Copy link
Collaborator

theecrit commented Aug 2, 2020

I'm not sure an entirely new classification system is necessary but I like the idea of challenging the limitations of existing classifications. When we're ready to dig into this, we should also be sure to center the conversation around the work WOEIP has already done here—they already have a set of actual environmental indicators (pdf attached, pp13-19).

We'll want to explore what a classification system implies:

  • Equity comparisons (WO compared to all of Oakland/AC/CA/et al)
  • Impacts (on health, transport, etc)
  • Impacts on WOCAP work (since they will be measuring actual changes in WO AQ to evaluate whether the strategies are working or not)

etc.

@kwonangela7
Copy link
Collaborator

kwonangela7 commented Apr 20, 2021

Per our conversation with him, Brian's recommendation is to use the 24 hr average EPA color standard for PM2.5 for our air quality readings on the map (source)
image

I think everything Jess mentioned above are still good things we should consider at some point. However, for the MVP let's stick with Brian's recommendation and use a standard for a 24 hour average even though woaq's air quality numbers for a single session (and even the comparison of sessions) are computed with real time data.

@theecrit theecrit changed the title As user, I would like a way to know how dangerous the air was during a particular session Style data points on the map to communicate meaning Apr 26, 2021
@theecrit theecrit added feature: map status: ready to work on Prioritized and ready for a contributor to move to "In Progress" and removed status: backlog Issue is not ready to be worked on. status: needs definition Issue needs more info to be ready to work on labels Apr 26, 2021
@kwonangela7
Copy link
Collaborator

@brooksjessup is working on the color coding with @kbrdsk, so I assigned both of them to this one. Since this is a larger ticket, we may end up having several assignees.

@TangoYankee
Copy link
Member Author

I see the third acceptance criteria: "see the min or max of air quality per 3 meters" used to be its own issue- #315 . I think it should be split back into its own issue for three reasons.

  1. The first two acceptance criteria are already complex
  2. The third criteria appears to be an independent feature
  3. I think we will want designs that clarify what it looks like to display the min and max, without cluttering or slowing down the map. Do we have those or can we link to them?

@TangoYankee
Copy link
Member Author

Per our conversation with him, Brian's recommendation is to use the 24 hr average EPA color standard for PM2.5 for our air quality readings on the map (source)

The classification for PM2.5 is available in this chart:
Measurement to AQI

The dustrak measures in mg. The conversion of m to μ is 10^3 μ to m.

@kwonangela7
Copy link
Collaborator

@theecrit tagging you for the comment above as I'm not sure if Github sent the notification due to some formatting issue I had when I first posted the comment.

@kwonangela7
Copy link
Collaborator

kwonangela7 commented Nov 2, 2021

Shoot @TangoYankee -- sorry, I should have made this more obvious on the ticket itself as opposed to just it being a comment but Brooks and Kabirdas actually implemented #2 in Mapbox itself! Kabirdas opened up PR #364 so that we could do stylings in Mapbox (and also use the one Brooks already created for #2, check it out here) that would show up on the website.

However, being that I'm not a web developer myself, I'm not sure if it's better to have it done on Mapbox and use Kabirdas' code to have it show up on the app, or to do it through React (as I'm guessing you did?). Anyway, sorry for this situation where we have two solutions for the same problem!

@TangoYankee
Copy link
Member Author

Having the feature depend on an outside style is fragile. If the map breaks or we need to change it, it is difficult or impossible for another developer to manage it.

The application is designed to use react and mapbox directly in the front end. This allows any developer to have direct access to how the data is displayed. It also gives us more control to optimize its performance and add new features, such as #331 .

@TangoYankee TangoYankee mentioned this issue Nov 6, 2021
6 tasks
@kwonangela7 kwonangela7 changed the title Style data points on the map to communicate meaning Display and color code readings on the map Nov 20, 2021
@kwonangela7 kwonangela7 added status: needs definition Issue needs more info to be ready to work on and removed status: ready to work on Prioritized and ready for a contributor to move to "In Progress" labels Nov 20, 2021
@kwonangela7
Copy link
Collaborator

kwonangela7 commented Nov 20, 2021

I went ahead and moved the third item into #315; thanks for your patience!

@TangoYankee I put this ticket back in needs definition b/c item #2 needs more. What I currently have for designs for item #2 are the wireframes for the Figma prototype linked in a previous comment. However, the design shows more requirements than what's on this ticket, so it needs to be further broken down to be useful for this ticket.

I'm going to try to set up a time with Jess to further clarify, and hope to have an update soon.

Sorry @TangoYankee, I misspoke back when I wrote this comment. #2 does have a design (as you've already implemented). The dot representing the reading along the path should take on the color of the max reading.

In the meantime, let me know if there's any other information that I need to provide to make this ticket ready to work on for a dev. Thanks! Not needed; Tim already finished this ticket!

@theecrit
Copy link
Collaborator

@kwonangela7

However, the design shows more requirements than what's on this ticket, so it needs to be further broken down to be useful for this ticket.

Are you referring to the pop-up for an individual geolocation? That is covered by #331 and is not within the scope of this issue, so shouldn't be a blocker. This issue is for the route path display only.

@kwonangela7
Copy link
Collaborator

@theecrit -- you're totally right, and I finally got around to updating the comment above. Sorry for the confusion!

@kwonangela7
Copy link
Collaborator

kwonangela7 commented Jan 12, 2022

@mnorelli, Tim actually has a PR open for this work! #380

I'm going to take you off as an assignee for this ticket since Tim completed it, but I added you as a reviewer to the PR as I thought you'd be a great person to do it! Hopefully this is okay with you, but take yourself as an assignee if not.

(Apologies that I didn't realize this work was already done 😅 )

@kwonangela7 kwonangela7 added status: ready to work on Prioritized and ready for a contributor to move to "In Progress" and removed status: needs definition Issue needs more info to be ready to work on labels Jan 12, 2022
@kwonangela7 kwonangela7 linked a pull request Jan 12, 2022 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: user interface feature: map milestone: MVP Required to ship status: ready to work on Prioritized and ready for a contributor to move to "In Progress"
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants