Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plato] NPE after step Transform Measured Values #215

Open
kraxner opened this issue Apr 9, 2014 · 1 comment
Open

[Plato] NPE after step Transform Measured Values #215

kraxner opened this issue Apr 9, 2014 · 1 comment
Labels

Comments

@kraxner
Copy link
Contributor

kraxner commented Apr 9, 2014

Maybe: If transformation is completed for a criterion, and the user goes back to Identify Requirements and changes the restriction of the ordinal scale, in way that already entered results are not covered by transformation, then it is possible to proceed after step Transform Measured Values, and a NPE occurs.

In OrdinalTransformer:

public boolean isTransformable(List<ValidationError> errors) {
    boolean result = true;
    for (String key: mapping.keySet()) {
        TargetValueObject value = mapping.get(key);

That is: we iterate over the keys of the defined mappings and check if they have defined target values.
What is missing:

  • Check also if there is a mapping defined for each measured value!

And more:

  • Check in Evaluate Experiments if already existing measurement values conform to ordinal restrictions!
@kraxner kraxner added the defect label Apr 9, 2014
@kraxner
Copy link
Contributor Author

kraxner commented Apr 9, 2014

Hard to reproduce... don't get past evaluation without a value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant