Detect JUnit version in PowerMockitoMockStaticToMockito (#919)

* Add failing test for JUnit 4 PowerMockito migration

Reproduces moderneinc/customer-requests#1925: when a test class uses
JUnit 4 (@org.junit.Test), ReplacePowerMockito should use @Before/@after
instead of @BeforeEach/@AfterEach.

* Detect JUnit version in PowerMockitoMockStaticToMockito

When a test class uses JUnit 4 (@org.junit.Test), the recipe now
uses @Before/@after from org.junit instead of always defaulting to
@BeforeEach/@AfterEach from JUnit Jupiter.

Fixes moderneinc/customer-requests#1925

Author: MBoegers

src/main/java/org/openrewrite/java/testing/mockito/PowerMockitoMockStaticToMockito.java

@@ -88,7 +88,8 @@ private static class PowerMockitoToMockitoVisitor extends JavaVisitor<ExecutionC
         public @Nullable J visit(@Nullable Tree tree, ExecutionContext ctx) {
             if (tree instanceof JavaSourceFile) {
                 boolean useTestNg = !FindAnnotations.find((J) tree, "@org.testng.annotations.Test").isEmpty();
-                initTestFrameworkInfo(useTestNg);
+                boolean useJunit4 = !useTestNg && !FindAnnotations.find((J) tree, "@org.junit.Test").isEmpty();
+                initTestFrameworkInfo(useTestNg, useJunit4);
             }
             return super.visit(tree, ctx);
         }
@@ -358,22 +359,29 @@ private J.ClassDeclaration removeExtension(J.ClassDeclaration classDecl, String
             return classDecl;
         }
 
-        private void initTestFrameworkInfo(boolean useTestNg) {
+        private void initTestFrameworkInfo(boolean useTestNg, boolean useJunit4) {
             String setUpMethodAnnotationName;
             String tearDownMethodAnnotationName;
             String annotationPackage;
 
-            if (!useTestNg) {
-                setUpMethodAnnotationName = "BeforeEach";
-                tearDownMethodAnnotationName = "AfterEach";
-                annotationPackage = "org.junit.jupiter.api";
-                additionalClasspathResource = "junit-jupiter-api-5";
-            } else {
+            if (useTestNg) {
                 setUpMethodAnnotationName = "BeforeMethod";
                 tearDownMethodAnnotationName = "AfterMethod";
                 annotationPackage = "org.testng.annotations";
                 additionalClasspathResource = "testng-7";
                 tearDownMethodAnnotationParameters = "(alwaysRun = true)";
+            } else if (useJunit4) {
+                setUpMethodAnnotationName = "Before";
+                tearDownMethodAnnotationName = "After";
+                annotationPackage = "org.junit";
+                additionalClasspathResource = "junit-4";
+                tearDownMethodAnnotationParameters = "";
+            } else {
+                setUpMethodAnnotationName = "BeforeEach";
+                tearDownMethodAnnotationName = "AfterEach";
+                annotationPackage = "org.junit.jupiter.api";
+                additionalClasspathResource = "junit-jupiter-api-5";
+                tearDownMethodAnnotationParameters = "";
             }
 
             this.setUpMethodAnnotation = "@" + setUpMethodAnnotationName;

src/test/java/org/openrewrite/java/testing/mockito/PowerMockitoMockStaticToMockitoTest.java

@@ -654,10 +654,9 @@ public void testStaticMethod() {
               """,
 
             """
+              import org.junit.After;
               import org.junit.Before;
               import org.junit.Test;
-              import org.junit.jupiter.api.AfterEach;
-              import org.junit.jupiter.api.BeforeEach;
               import org.mockito.MockedStatic;
               import org.mockito.Mockito;
               import test.A;
@@ -670,14 +669,10 @@ public class MyTest {
 
                   @Before
                   void setUp() {
-                  }
-
-                  @BeforeEach
-                  void setUpStaticMocks() {
                       mockedA_B = Mockito.mockStatic(A.B.class);
                   }
 
-                  @AfterEach
+                  @After
                   void tearDownStaticMocks() {
                       mockedA_B.closeOnDemand();
                   }
@@ -772,4 +767,60 @@ fun testStaticMethod() {
           )
         );
     }
+
+    @Issue("https://github.com/moderneinc/customer-requests/issues/1925")
+    @Test
+    void junit4PrepareForTestUsesBeforeAndAfter() {
+        //language=java
+        rewriteRun(
+          java(
+            """
+              import static org.mockito.Mockito.mockStatic;
+
+              import java.util.Calendar;
+
+              import org.junit.Test;
+              import org.powermock.core.classloader.annotations.PrepareForTest;
+
+              @PrepareForTest({Calendar.class})
+              public class MyTest {
+
+                  @Test
+                  public void testStaticMethod() {
+                      mockStatic(Calendar.class);
+                  }
+              }
+              """,
+            """
+              import static org.mockito.Mockito.mockStatic;
+
+              import java.util.Calendar;
+
+              import org.junit.After;
+              import org.junit.Before;
+              import org.junit.Test;
+              import org.mockito.MockedStatic;
+
+              public class MyTest {
+
+                  private MockedStatic<Calendar> mockedCalendar;
+
+                  @Before
+                  void setUpStaticMocks() {
+                      mockedCalendar = mockStatic(Calendar.class);
+                  }
+
+                  @After
+                  void tearDownStaticMocks() {
+                      mockedCalendar.closeOnDemand();
+                  }
+
+                  @Test
+                  public void testStaticMethod() {
+                  }
+              }
+              """
+          )
+        );
+    }
 }