Skip to content

Commit dc526f2

Browse files
committed
UPSTREAM: <carry>: Remove some unnecessary sig-network test skips
The ClusterDns and Firewall tests no longer exist. The Topology Hints test was renamed (`[Feature:Topology Hints]` went away when the feature became GA), and we already have a separate skip rule for the new name. The two service tests that were skipped because they require SSH got rewritten at some point to use a HostNetwork pod instead.
1 parent 5c9df33 commit dc526f2

File tree

1 file changed

+11
-18
lines changed

1 file changed

+11
-18
lines changed

openshift-hack/cmd/k8s-tests-ext/disabled_tests.go

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -52,9 +52,6 @@ func filterOutDisabledSpecs(specs et.ExtensionTestSpecs) et.ExtensionTestSpecs {
5252

5353
"Firewall rule should have correct firewall rules for e2e cluster", // Upstream-install specific
5454

55-
// https://bugzilla.redhat.com/show_bug.cgi?id=2079958
56-
"[sig-network] [Feature:Topology Hints] should distribute endpoints evenly",
57-
5855
// Tests require SSH configuration and is part of the parallel suite, which does not create the bastion
5956
// host. Enabling the test would result in the bastion being created for every parallel test execution.
6057
// Given that we have existing oc and WMCO tests that cover this functionality, we can safely disable it.
@@ -68,21 +65,20 @@ func filterOutDisabledSpecs(specs et.ExtensionTestSpecs) et.ExtensionTestSpecs {
6865
// tests that are known broken and need to be fixed upstream or in openshift
6966
// always add an issue here
7067
"Broken": {
71-
"mount an API token into pods", // We add 6 secrets, not 1
72-
"ServiceAccounts should ensure a single API token exists", // We create lots of secrets
73-
"unchanging, static URL paths for kubernetes api services", // the test needs to exclude URLs that are not part of conformance (/logs)
74-
"Services should be able to up and down services", // we don't have wget installed on nodes
75-
"KubeProxy should set TCP CLOSE_WAIT timeout", // the test require communication to port 11302 in the cluster nodes
76-
"should check kube-proxy urls", // previously this test was skipped b/c we reported -1 as the number of nodes, now we report proper number and test fails
77-
"SSH", // TRIAGE
78-
"should implement service.kubernetes.io/service-proxy-name", // this is an optional test that requires SSH. sig-network
79-
"recreate nodes and ensure they function upon restart", // https://bugzilla.redhat.com/show_bug.cgi?id=1756428
80-
"[Driver: iscsi]", // https://bugzilla.redhat.com/show_bug.cgi?id=1711627
68+
"mount an API token into pods", // We add 6 secrets, not 1
69+
"ServiceAccounts should ensure a single API token exists", // We create lots of secrets
70+
"unchanging, static URL paths for kubernetes api services", // the test needs to exclude URLs that are not part of conformance (/logs)
71+
"Services should be able to up and down services", // we don't have wget installed on nodes
72+
"KubeProxy should set TCP CLOSE_WAIT timeout", // the test require communication to port 11302 in the cluster nodes
73+
"should check kube-proxy urls", // previously this test was skipped b/c we reported -1 as the number of nodes, now we report proper number and test fails
74+
"SSH", // TRIAGE
75+
"recreate nodes and ensure they function upon restart", // https://bugzilla.redhat.com/show_bug.cgi?id=1756428
76+
"[Driver: iscsi]", // https://bugzilla.redhat.com/show_bug.cgi?id=1711627
8177

8278
"RuntimeClass should reject",
8379

84-
"Services should implement service.kubernetes.io/headless", // requires SSH access to function, needs to be refactored
85-
"ClusterDns [Feature:Example] should create pod that uses dns", // doesn't use bindata, not part of kube test binary
80+
"Services should implement service.kubernetes.io/headless", // test is broken, https://issues.k8s.io/134321
81+
8682
"Simple pod should return command exit codes should handle in-cluster config", // kubectl cp doesn't work or is not preserving executable bit, we have this test already
8783

8884
// TODO(node): configure the cri handler for the runtime class to make this work
@@ -131,9 +127,6 @@ func filterOutDisabledSpecs(specs et.ExtensionTestSpecs) et.ExtensionTestSpecs {
131127
"[sig-network] Networking Granular Checks: Services should function for service endpoints using hostNetwork",
132128
"[sig-network] Networking Granular Checks: Services should function for pod-Service(hostNetwork)",
133129

134-
// https://bugzilla.redhat.com/show_bug.cgi?id=1952460
135-
"[sig-network] Firewall rule control plane should not expose well-known ports",
136-
137130
// https://bugzilla.redhat.com/show_bug.cgi?id=1988272
138131
"[sig-network] Networking should provide Internet connection for containers [Feature:Networking-IPv6]",
139132
"[sig-network] Networking should provider Internet connection for containers using DNS",

0 commit comments

Comments
 (0)