Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followups to build webhook trigger secret references #17496

Open
2 of 5 tasks
bparees opened this issue Nov 28, 2017 · 5 comments
Open
2 of 5 tasks

followups to build webhook trigger secret references #17496

bparees opened this issue Nov 28, 2017 · 5 comments
Assignees
Labels
area/techdebt component/build lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P2

Comments

@bparees
Copy link
Contributor

bparees commented Nov 28, 2017

Follow ups to:
#17314

Unfortunately changes to new-app and the quickstarts won't be backwards compatible, so we can't change new-app until 3.10. Not sure when we'd want to change the quickstarts.

/cc @jim-minter

@bparees bparees self-assigned this Nov 28, 2017
@bparees
Copy link
Contributor Author

bparees commented Nov 28, 2017

@jwforres is it going to cause you problems if we stop reporting the value of the secret used to trigger a build for builds triggered by a webhook?

@bparees
Copy link
Contributor Author

bparees commented Nov 28, 2017

(or if we just start reporting it as all asterisks)

@jwforres
Copy link
Member

@bparees i dont see any refs to buildtriggercause in the console, so no dont think so

bparees added a commit to bparees/origin that referenced this issue Feb 1, 2018
bparees added a commit to bparees/origin that referenced this issue Feb 1, 2018
bparees added a commit to bparees/origin that referenced this issue Feb 1, 2018
bparees added a commit to bparees/origin that referenced this issue Feb 1, 2018
@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 2, 2018
@bparees
Copy link
Contributor Author

bparees commented May 2, 2018

/remove-lifecycle stale
/lifecycle frozen

@openshift-ci-robot openshift-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/techdebt component/build lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/P2
Projects
None yet
Development

No branches or pull requests

4 participants