Added support for Get All Users for a Role. Updated Assembly to v1.1.3.3

Author: Alan Quillin

src/corelib/Properties/AssemblyInfo.cs

@@ -32,8 +32,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.1.3.2")]
-[assembly: AssemblyFileVersion("1.1.3.2")]
+[assembly: AssemblyVersion("1.1.3.3")]
+[assembly: AssemblyFileVersion("1.1.3.3")]
 
 [assembly: InternalsVisibleTo("OpenStackNet.Testing.Integration")]
 [assembly: InternalsVisibleTo("OpenStackNet.Testing.Unit")]

src/corelib/Providers/Rackspace/CloudIdentityProvider.cs

@@ -60,6 +60,13 @@ public IEnumerable<Role> ListRoles(string serviceId = null, string markerId = nu
             return provider.ListRoles(serviceId, markerId, limit, identity);
         }
 
+        /// <inheritdoc/>
+        public IEnumerable<User> ListUsersByRole(string roleId, bool? enabled = null, int? marker = null, int? limit = null, CloudIdentity identity = null)
+        {
+            var provider = GetProvider(identity);
+            return provider.ListUsersByRole(roleId, enabled, marker, limit, identity);
+        }
+
         public Role AddRole(string name, string descritpion, CloudIdentity identity)
         {
             var provider = GetProvider(identity);

src/corelib/Providers/Rackspace/GeographicalCloudIdentityProvider.cs

@@ -107,6 +107,39 @@ public bool DeleteRoleFromUser(string userId, string roleId, CloudIdentity ident
             return false;
         }
 
+        /// <inheritdoc/>
+        public IEnumerable<User> ListUsersByRole(string roleId, bool? enabled = null, int? markerId = null, int? limit = null, CloudIdentity identity = null)
+        {
+            if (limit < 0 || limit > 1000)
+                throw new ArgumentOutOfRangeException("limit");
+
+            var parameters = BuildOptionalParameterList(new Dictionary<string, string>
+                {
+                    {"enabled", !enabled.HasValue ? null : enabled.Value ? "true" : "false"},
+                    {"marker", !markerId.HasValue ? null : markerId.Value.ToString()},
+                    {"limit", !limit.HasValue ? null : limit.Value.ToString()},
+                });
+
+            var urlPath = string.Format("/v2.0/OS-KSADM/roles/{0}/RAX-AUTH/users", roleId);
+            var response = ExecuteRESTRequest<UsersResponse>(identity, urlPath, HttpMethod.GET, queryStringParameter: parameters);
+
+            if (response == null || response.Data == null)
+                return null;
+            // Due to the fact the sometimes the API returns a JSON array of users and sometimes it returns a single JSON user object.  
+            // Therefore if we get a null data object (which indicates that the deserializer could not parse to an array) we need to try and parse as a single User object.
+            if (response.Data.Users == null)
+            {
+                var userResponse = JsonConvert.DeserializeObject<UserResponse>(response.RawBody);
+
+                if (response == null || response.Data == null)
+                    return null;
+
+                return new[] { userResponse.User };
+            }
+
+            return response.Data.Users;
+        }
+
         #endregion
 
         #region Credentials

src/corelib/Providers/Rackspace/IExtendedCloudIdentityProvider.cs

@@ -1,6 +1,7 @@
-using System.Collections.Generic;
-using net.openstack.Core;
+using System;
+using System.Collections.Generic;
 using net.openstack.Core.Domain;
+using net.openstack.Core.Exceptions.Response;
 using net.openstack.Core.Providers;
 
 namespace net.openstack.Providers.Rackspace
@@ -17,6 +18,21 @@ public interface IExtendedCloudIdentityProvider : IIdentityProvider
         /// <returns>List of <see cref="Role"/></returns>
         IEnumerable<Role> ListRoles(string serviceId = null, string markerId = null, int? limit = null, CloudIdentity identity = null);
 
+        /// <summary>
+        /// Lists all users by role.
+        /// </summary>
+        /// <param name="roleId">The role ID. The behavior is unspecified if this is not obtained from <see cref="Role.Id"/>.</param>
+        /// <param name="enabled">Allows you to filter enabled or un-enabled users. If the value is <c>null</c>, a provider-specific default value is used.</param>
+        /// <param name="marker">The index of the last item in the previous list. Used for pagination. If the value is <c>null</c>, the list starts at the beginning.</param>
+        /// <param name="limit">Indicates the maximum number of items to return. Used for pagination. If the value is <c>null</c>, a provider-specific default value is used.</param>
+        /// <param name="identity">The cloud identity to use for this request. If not specified, the default identity for the current provider instance will be used.</param>
+        /// <returns>A collection of <see cref="Role"/> objects describing the requested roles.</returns>
+        /// <exception cref="ArgumentOutOfRangeException">If <paramref name="limit"/> is less than 0 or greater than 1000.</exception>
+        /// <exception cref="NotSupportedException">If the provider does not support the given <paramref name="identity"/> type.</exception>
+        /// <exception cref="InvalidOperationException">If <paramref name="identity"/> is <c>null</c> and no default identity is available for the provider.</exception>
+        /// <exception cref="ResponseException">If the REST API request failed.</exception>
+        IEnumerable<User> ListUsersByRole(string roleId, bool? enabled = null, int? marker = null, int? limit = null, CloudIdentity identity = null);
+
         /// <summary>
         /// Create a new role.
         /// </summary>