Skip to content

1160 include cypress binary in repository #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rudivanhierden wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

1160 include cypress binary in repository #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
9ad3c9a
feat(cypress): vendor binary & update Cypress
rudivanhierden Nov 18, 2025
6306993
chore: delete knox
rudivanhierden Nov 18, 2025
047ff9f
chore: add knox
rudivanhierden Nov 18, 2025
a47778a
ci: upgrade checkout to v5 and enable LFS support
rudivanhierden Nov 18, 2025
abf4b63
chore: set Cypress install binary in `npm ci` cmd
rudivanhierden Nov 18, 2025
513fc20
chore: include Cypress binary in Docker build process
rudivanhierden Nov 18, 2025
63fcbed
ci: set Cypress binary path in npm ci command
rudivanhierden Nov 18, 2025
350acd6
chore: update Cypress binary path in Docker build configuration
rudivanhierden Nov 18, 2025
69a0ade
chore: update Cypress binary path to use GITHUB_WORKSPACE in Docker b…
rudivanhierden Nov 18, 2025
27925a0
fix: add missing dollar sign for env
rudivanhierden Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
vendor/*.zip filter=lfs diff=lfs merge=lfs -text
vendor/*.tar.gz filter=lfs diff=lfs merge=lfs -text
28 changes: 17 additions & 11 deletions .github/workflows/build-publish-docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
build_id: ${{ steps.set_build_id.outputs.build_id }}
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false
Expand All @@ -50,7 +50,7 @@ jobs:
openstad_version: ${{ steps.chart_version.outputs.openstad_version }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false
Expand All @@ -69,7 +69,7 @@ jobs:
pull-requests: read
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false
Expand All @@ -95,8 +95,9 @@ jobs:
pull-requests: read
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand All @@ -105,7 +106,7 @@ jobs:
node-version: 24

- name: Install dependencies
run: npm i
run: CYPRESS_INSTALL_BINARY=$GITHUB_WORKSPACE/vendor/cypress-15.6.0.zip npm ci --legacy-peer-deps

- name: Run Vitest tests
run: npm run test:unit
Expand All @@ -120,8 +121,9 @@ jobs:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand All @@ -130,7 +132,7 @@ jobs:
node-version: 24

- name: Install dependencies
run: npm ci --legacy-peer-deps
run: CYPRESS_INSTALL_BINARY=$GITHUB_WORKSPACE/vendor/cypress-15.6.0.zip npm ci --legacy-peer-deps

- name: Run Cypress tests
uses: cypress-io/github-action@v6
Expand All @@ -154,8 +156,9 @@ jobs:
contents: read
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand Down Expand Up @@ -203,8 +206,9 @@ jobs:
BUILD_TARGET: release
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand Down Expand Up @@ -283,8 +287,9 @@ jobs:
contents: read
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand Down Expand Up @@ -376,8 +381,9 @@ jobs:

steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
lfs: true
ref: ${{ github.event_name == 'workflow_dispatch' && github.event.inputs.branch || github.ref }}
persist-credentials: false

Expand Down
1 change: 1 addition & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ENV BUILD_ENV=${BUILD_ENV}

# set Cypress cache to a writable temp path (avoids issues with /root/.cache)
ENV CYPRESS_CACHE_FOLDER=/tmp/CypressCache
ENV CYPRESS_INSTALL_BINARY=/opt/openstad-headless/vendor/cypress-15.6.0.zip

RUN npm ci --legacy-peer-deps -ws

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"private": true,
"devDependencies": {
"@trivago/prettier-plugin-sort-imports": "^4.3.0",
"cypress": "^15.3.0",
"cypress": "^15.6.0",
"mysql2": "^3.11.3",
"prettier": "3.0.3",
"vitest": "^3.2.3"
Expand Down
3 changes: 3 additions & 0 deletions vendor/cypress-15.6.0.zip
View file
Open in desktop
Git LFS file not shown
Binary file modified vendor/knox-0.9.3.tar.gz
View file
Open in desktop
Binary file not shown.