How to build src/ucs/stats/stats_reader.c ?

[Honggang-LI]

src/ucs/stats/stats_reader.c depends on gtk and other libraries. As there are multiple versions of gtk available, I don't know which version (gtk-4, gtk-3, gtk-2) should be used.

gcc -DHAVE_CONFIG_H -DCPU_FLAGS= -I/home/fc34/reading/ucx-v1.10.1-do-not-update/src -I/home/fc34/reading/ucx-v1.10.1-do-not-update -I/home/fc34/reading/ucx-v1.10.1-do-not-update/src -DUCX_MODULE_DIR=\"/tmp/ucx/lib/ucx\" -O0 -D_DEBUG \
-g --coverage  -I/usr/include/gtk-4.0   -I/usr/lib64/glib-2.0/include -I/usr/include/glib-2.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz  -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/graphene-1.0 -I/usr/lib64/graphene-1.0/include -c  stats_reader.c -o stats_reader.o

I tried to build it with something like this. But it failed with a lot of warning messages.

My computer is running Fedora-34 x86_64. Please provide working script to build stats_reader.c.

thanks

[yosefe]

stats_reader.c code is a leftover and currently not built by default. AFAIR, last time it worked on Centos7

[Honggang-LI]

Can you please share Centos7 script?

[yosefe]

it should be something like gcc src/ucs/stats/stats_reader.c $(pkg-config --cflags gtk+-2.0) $(pkg-config --libs gtk+-2.0).
however, the code is outdated and will not compile as-is, we probably need to remove it altogether.

[Honggang-LI]

diff --git a/src/ucs/stats/stats_reader.c b/src/ucs/stats/stats_reader.c
index 432b04b11..93cb04ce8 100644
--- a/src/ucs/stats/stats_reader.c
+++ b/src/ucs/stats/stats_reader.c
@@ -74,7 +74,7 @@ static void fill_model(ucs_stats_node_t *node, GtkTreeIter *parent, int depth)
         }
     }
 
-    list_for_each(child, &node->children[UCS_STATS_ACTIVE_CHILDREN], list) {
+    ucs_list_for_each(child, &node->children[UCS_STATS_ACTIVE_CHILDREN], list) {
         fill_model(child, &tree_elem, depth + 1);
     }
 }
@@ -82,7 +82,7 @@ static void fill_model(ucs_stats_node_t *node, GtkTreeIter *parent, int depth)
 static gboolean update_view(GtkCellRenderer *renderer)
 {
     ucs_stats_node_t *root;
-    list_link_t *stats;
+    ucs_list_link_t *stats;
     GtkTreeModel *model;
 
     /* Get stats */
@@ -95,7 +95,7 @@ static gboolean update_view(GtkCellRenderer *renderer)
 
     /* Re-fill the model */
     gtk_tree_store_clear(g_treestore);
-    list_for_each(root, stats, list) {
+    ucs_list_for_each(root, stats, list) {
         fill_model(root, NULL, 0);
     }

After applied this simple patch, I managed to build stats_reader.c with gtk3 library. The gcc flags were set with $(pkg-config --cflags gtk+-3.0) $(pkg-config --libs gtk+-3.0) . My computer is running Fedora-34 x64.

Thanks