Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add Support for MLX Frontend #24340

Closed
1 task done
NripeshN opened this issue May 2, 2024 · 5 comments
Closed
1 task done

[Feature Request]: Add Support for MLX Frontend #24340

NripeshN opened this issue May 2, 2024 · 5 comments
Labels
enhancement New feature or request feature New feature request

Comments

@NripeshN
Copy link

NripeshN commented May 2, 2024

Request Description

I am writing to propose the inclusion of support for the MLX frontend in the OpenVINO toolkit.

Issue submission checklist

  • The feature request or improvement must be related to OpenVINO
@NripeshN NripeshN added enhancement New feature or request feature New feature request labels May 2, 2024
@rkazants
Copy link
Contributor

rkazants commented May 2, 2024

Hi @NripeshN,

It is quite interesting. I see it is young framework and already collected 28k stars in GitHub. Really great work!

However, is there any objective reason about why research scientist and engineers will select MLX framework for training new models instead of PyTorch? We observe PyTorch to keep a trend despite some new frameworks like JAX, MindSpore made attempts to accelerate training, etc. but anyway scientists select PyTorch. That seems a fact. So our current efforts are absolutely concentrated around PyTorch models support.

In the meantime, we are always open and welcome to our external contributors who want to add new frontend. We can provide more details about how to do this and support this contribution.

Best regards,
Roman

@NripeshN
Copy link
Author

NripeshN commented May 2, 2024

is there any objective reason about why research scientist and engineers will select MLX framework for training new models instead of PyTorch?

Hi @rkazants
I think this comment ml-explore/mlx#12 (comment) explains this in detail. I'd love to contribute and try add this new frontend. Could you please provide me more details to do so?

@rkazants
Copy link
Contributor

rkazants commented May 2, 2024

Hi @rkazants I think this comment ml-explore/mlx#12 (comment) explains this in detail. I'd love to contribute and try add this new frontend. Could you please provide me more details to do so?

@NripeshN, cool! Give me some time and I will be back with instructions.

Best regards,
Roman

@slyalin
Copy link
Contributor

slyalin commented May 2, 2024

@NripeshN, thank you for your interest!

Could you elaborate a bit on proposed workflow and technical side of the proposal? I suppose that we can catch the compute graph from MLX at the same point when mx.eval or mx.compile is called. So it wouldn't suppose that we need to trace something at the level of OpenVINO frontend, and graph representation is provided by MLX itself instead. Right? Could you point to some description that gives the understanding how this graph looks like? Does it have C++ or Python API to access the nodes?

@andrei-kochin
Copy link
Contributor

@NripeshN any updates on the question above?

@NripeshN NripeshN closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New feature request
Projects
None yet
Development

No branches or pull requests

4 participants