WPA OpenCL formats: Bugfix for adding vector size to algorithm_name

magnumripper · magnumripper · commit 9bf35c00b75e · 2025-11-19T09:55:03.000+01:00
An snprintf always ended up truncated after some change to ALGORITHM_NAME.
This fix is future safe.
diff --git a/src/opencl_wpapmk_fmt_plug.c b/src/opencl_wpapmk_fmt_plug.c
@@ -198,7 +198,7 @@ static char* get_key(int index)
 
 static void init(struct fmt_main *_self)
 {
-	static char valgo[32] = "";
+	static char valgo[sizeof(ALGORITHM_NAME) + 12] = "";
 
 	self = _self;
 
diff --git a/src/opencl_wpapsk_fmt_plug.c b/src/opencl_wpapsk_fmt_plug.c
@@ -214,7 +214,7 @@ static char* get_key(int index)
 
 static void init(struct fmt_main *_self)
 {
-	static char valgo[32] = "";
+	static char valgo[sizeof(ALGORITHM_NAME) + 12] = "";
 
 	self = _self;
 

Original file line number	Diff line number	Diff line change
`@@ -198,7 +198,7 @@ static char* get_key(int index)`
`198`	`198`
`199`	`199`	`static void init(struct fmt_main *_self)`
`200`	`200`	`{`
`201`		`- static char valgo[32] = "";`
	`201`	`+ static char valgo[sizeof(ALGORITHM_NAME) + 12] = "";`
`202`	`202`
`203`	`203`	`self = _self;`
`204`	`204`
Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ static char* get_key(int index)`
`214`	`214`
`215`	`215`	`static void init(struct fmt_main *_self)`
`216`	`216`	`{`
`217`		`- static char valgo[32] = "";`
	`217`	`+ static char valgo[sizeof(ALGORITHM_NAME) + 12] = "";`
`218`	`218`
`219`	`219`	`self = _self;`
`220`	`220`